Bug 164720 - Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
Summary: Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-14 11:10 PST by Alex Christensen
Modified: 2016-11-14 22:08 PST (History)
3 users (show)

See Also:

Attachments
Patch (148.54 KB, patch)
2016-11-14 11:12 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (131.76 KB, patch)
2016-11-14 14:22 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (134.14 KB, patch)
2016-11-14 15:06 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (134.12 KB, patch)
2016-11-14 15:43 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (140.65 KB, patch)
2016-11-14 16:19 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.49 MB, application/zip)
2016-11-14 17:15 PST, Build Bot 		no flags Details
Patch (144.19 KB, patch)
2016-11-14 17:28 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.74 MB, application/zip)
2016-11-14 18:29 PST, Build Bot 		no flags Details
Patch (143.97 KB, patch)
2016-11-14 20:26 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-11-14 11:10:44 PST 
Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
Comment 1 Alex Christensen 2016-11-14 11:12:07 PST 
Created attachment 294719 [details]
Patch
Comment 2 Alex Christensen 2016-11-14 14:22:52 PST 
Created attachment 294746 [details]
Patch
Comment 3 Alex Christensen 2016-11-14 15:06:50 PST 
Created attachment 294756 [details]
Patch
Comment 4 Brady Eidson 2016-11-14 15:34:39 PST 
Comment on attachment 294756 [details]
Patch

After 100% green on EWS, yes.
Comment 5 Alex Christensen 2016-11-14 15:43:58 PST 
Created attachment 294766 [details]
Patch
Comment 6 Alex Christensen 2016-11-14 16:19:06 PST 
Created attachment 294772 [details]
Patch
Comment 7 Build Bot 2016-11-14 17:15:45 PST 
Comment on attachment 294772 [details]
Patch

Attachment 294772 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2516689

New failing tests:
fast/mediastream/MediaDevices-enumerateDevices.html
fast/mediastream/enumerating-crash.html
Comment 8 Build Bot 2016-11-14 17:15:47 PST 
Created attachment 294782 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 9 Alex Christensen 2016-11-14 17:28:22 PST 
Created attachment 294785 [details]
Patch
Comment 10 Build Bot 2016-11-14 18:29:26 PST 
Comment on attachment 294785 [details]
Patch

Attachment 294785 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2517039

New failing tests:
fast/mediastream/MediaDevices-enumerateDevices.html
fast/mediastream/enumerating-crash.html
Comment 11 Build Bot 2016-11-14 18:29:29 PST 
Created attachment 294796 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 12 Alex Christensen 2016-11-14 20:26:56 PST 
Created attachment 294801 [details]
Patch
Comment 13 WebKit Commit Bot 2016-11-14 22:08:16 PST 
Comment on attachment 294801 [details]
Patch

Clearing flags on attachment: 294801

Committed r208727: <http://trac.webkit.org/changeset/208727>
Comment 14 WebKit Commit Bot 2016-11-14 22:08:21 PST 
All reviewed patches have been landed.  Closing bug.