Bug 164706 - Remove many includes of ExceptionCode.h
Summary: Remove many includes of ExceptionCode.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-13 18:53 PST by Darin Adler
Modified: 2016-11-14 09:59 PST (History)
3 users (show)

See Also:

Attachments
Patch (75.98 KB, patch)
2016-11-13 20:00 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (77.10 KB, patch)
2016-11-13 20:02 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (84.30 KB, patch)
2016-11-13 22:43 PST, Darin Adler 		achristensen: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-11-13 18:53:34 PST 
Remove many includes of ExceptionCode.h
Comment 1 Darin Adler 2016-11-13 20:00:29 PST 
Created attachment 294689 [details]
Patch
Comment 2 Darin Adler 2016-11-13 20:02:49 PST 
Created attachment 294690 [details]
Patch
Comment 3 Darin Adler 2016-11-13 22:43:27 PST 
Created attachment 294693 [details]
Patch
Comment 4 Alex Christensen 2016-11-14 07:35:07 PST 
Comment on attachment 294693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294693&action=review

> Source/WebCore/Modules/webdatabase/Database.cpp:181
> +using GuidDatabaseMap = HashMap<DatabaseGUID, std::unique_ptr<HashSet<Database*>>>;

Could we get rid of the unique_ptr here?
Comment 5 WebKit Commit Bot 2016-11-14 08:00:35 PST 
Comment on attachment 294693 [details]
Patch

Rejecting attachment 294693 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 294693, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
0-ab3c-d52691b4dbfc ...
Currently at 208680 = 60ab07e7402f70b0feef683c6d95233ae67b963a
r208681 = 20904491d96b304c2b42cfd0c9dac23089ca51a4
r208682 = f0fcd5a65b62bb57ab12a7c5e39d9d1dc2828bf4
r208683 = da335709346b23bbb626212f35cccde87784b565
r208684 = 9bcba2339b23e84b6fa2bb2907e906485062586d
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/2514166
Comment 6 Darin Adler 2016-11-14 09:24:24 PST 
Comment on attachment 294693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294693&action=review

>> Source/WebCore/Modules/webdatabase/Database.cpp:181
>> +using GuidDatabaseMap = HashMap<DatabaseGUID, std::unique_ptr<HashSet<Database*>>>;
> 
> Could we get rid of the unique_ptr here?

Sure. The hard thing for me when doing something like this is deciding where to stop. I often see things like unnecessary heap allocations or even algorithms that iterate an entire collection rather than keeping something that’s indexed, and it’s hard for me to know which to change in a given patch. I suppose the downside is that the map might be larger because empty cells would be considerably larger.
Comment 7 Darin Adler 2016-11-14 09:59:08 PST 
Committed r208688: <http://trac.webkit.org/changeset/208688>