Bug 164695 - Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations
Summary: Enhance run-jsc-stress-test script to allow optional test specific options to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 155145 164701
  Show dependency tree / graph
 
Reported: 2016-11-12 19:43 PST by Mark Lam
Modified: 2016-11-14 10:32 PST (History)
8 users (show)

See Also:

Attachments
proposed patch. (15.35 KB, patch)
2016-11-12 19:52 PST, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-11-12 19:43:31 PST 
This gives us more flexibility when specific tests needs to enable special JSC options in order to exercise specific code paths.  It also saves us from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest.  We can now just use runFTLNoCJIT in its place.
Comment 1 Mark Lam 2016-11-12 19:52:42 PST 
Created attachment 294647 [details]
proposed patch.
Comment 2 JF Bastien 2016-11-13 10:26:17 PST 
Nice, lgtm!
Comment 3 Keith Miller 2016-11-14 10:26:47 PST 
Comment on attachment 294647 [details]
proposed patch.

seems reasonable.
Comment 4 Mark Lam 2016-11-14 10:32:46 PST 
Thanks for the review.  Landed in r208692: <http://trac.webkit.org/r208692>.