Bug 164679 – Web Inspector: SourceCodeTextEditor should display execution lines for background threads

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
SourceCodeTextEditor should display execution lines for background threads

Currently we only show the execution line for the active call frame. However, users may be looking at a file which contains the current paused execution line for a background thread, or even have two Workers paused in the same "worker.js" script. Whenever targets are paused, we should be showing their execution line.

Notes:
- Xcode has a nice inline message, like inline error messages, indicating the name of the other thread paused at that location.

[Radar WebKit Bug Importer]

<rdar://problem/29233026>

[Matt Baker]

I like including an inline message similar to our inline errors/warnings for execution lines. Would execution lines belonging to background threads be styled differently than the line associated with the active call frame? It might be nice to use opacity (or some other style) to de-emphasize execution lines for inactive call frames.

What if two threads are paused at the same location in the same script? Maybe we could indicate something in the inline message, like having a disclosure triangle.

[Timothy Hatcher]

(In reply to comment #2)
> I like including an inline message similar to our inline errors/warnings for
> execution lines. Would execution lines belonging to background threads be
> styled differently than the line associated with the active call frame? It
> might be nice to use opacity (or some other style) to de-emphasize execution
> lines for inactive call frames.
> 
> What if two threads are paused at the same location in the same script?
> Maybe we could indicate something in the inline message, like having a
> disclosure triangle.

Currently threads are limited to whole worker scripts, so there is never a mix. In the future we might want to consider things that you mention.

[Joseph Pecoraro]

> > What if two threads are paused at the same location in the same script?
> > Maybe we could indicate something in the inline message, like having a
> > disclosure triangle.
> 
> Currently threads are limited to whole worker scripts, so there is never a
> mix. In the future we might want to consider things that you mention.

This is possible right now. If two workers are spawned with the same script ("worker.js") then we should show both in the SourceCodeTextEditor for that script.

[Joseph Pecoraro]

Created attachment 294774 [details]
[PATCH] Proposed Fix

Probably won't apply

[Joseph Pecoraro]

Created attachment 294775 [details]
[IMAGE] Thread Line Indicator - Multiple Threads in the same Resource

[Build Bot]

Comment on attachment 294774 [details]
[PATCH] Proposed Fix

Attachment 294774 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2516778

New failing tests:
js/regress-141098.html

[Build Bot]

Created attachment 294788 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Comment on attachment 294788 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

Failure appears unrelated.

[Timothy Hatcher]

Comment on attachment 294774 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=294774&action=review

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:714
> +        }
> +        threads.push(target);

Nit: newline between.

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:730
> +        threads.remove(target);
> +        if (threads.length) {

Nit: newline between.

[WebKit Commit Bot]

Comment on attachment 294774 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 294774

Committed r208783: <http://trac.webkit.org/changeset/208783>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.