,
<rdar://problem/29028964>
Created attachment 294581 [details] Proposed Fix
Attachment 294581 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:5291: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 294581 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=294581&action=review > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:143 > + Inspector::FrontendChannel* channel = nullptr; > + std::swap(channel, m_remoteChannel); > + if (channel) > + m_frontendRouter->disconnectFrontend(channel); This swap seems overkill. I'd rather make it easy to search for "m_remoteChannel =". Perhaps: if (Inspector::FrontendChannel* channel = m_remoteChannel) { m_remoteChannel = nullptr; m_frontendRouter->disconnectFrontend(channel); } > Source/WebKit2/UIProcess/WebPageProxy.cpp:5291 > + if (m_controlledByAutomation) Style: Braces
Created attachment 294588 [details] For EWS
Attachment 294588 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:5291: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 294588 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=294588&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:5291 > + if (m_controlledByAutomation) Style still.
Created attachment 294626 [details] For EWS
Comment on attachment 294626 [details] For EWS Clearing flags on attachment: 294626 Committed r208657: <http://trac.webkit.org/changeset/208657>
All reviewed patches have been landed. Closing bug.