Bug 164671 – Web Automation: terminate the automation session if the web process crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Blaze Burg]

,

[Blaze Burg]

<rdar://problem/29028964>

[Blaze Burg]

Created attachment 294581 [details]
Proposed Fix

[WebKit Commit Bot]

Attachment 294581 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:5291:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 294581 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=294581&action=review

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:143
> +    Inspector::FrontendChannel* channel = nullptr;
> +    std::swap(channel, m_remoteChannel);
> +    if (channel)
> +        m_frontendRouter->disconnectFrontend(channel);

This swap seems overkill. I'd rather make it easy to search for "m_remoteChannel =". Perhaps:

    if (Inspector::FrontendChannel* channel = m_remoteChannel) {
        m_remoteChannel = nullptr;
        m_frontendRouter->disconnectFrontend(channel);
    }

> Source/WebKit2/UIProcess/WebPageProxy.cpp:5291
> +    if (m_controlledByAutomation)

Style: Braces

[Blaze Burg]

Created attachment 294588 [details]
For EWS

[WebKit Commit Bot]

Attachment 294588 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:5291:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 294588 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=294588&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:5291
> +    if (m_controlledByAutomation)

Style still.

[Blaze Burg]

Created attachment 294626 [details]
For EWS

[WebKit Commit Bot]

Comment on attachment 294626 [details]
For EWS

Clearing flags on attachment: 294626

Committed r208657: <http://trac.webkit.org/changeset/208657>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.