Bug 164668 – Relocate wasm tests and actually add them to the test runner

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Relocate wasm tests and actually add them to the test runner

[Keith Miller]

Created attachment 294571 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 294571 [details]
Patch

r=me

[Joseph Pecoraro]

Comment on attachment 294571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294571&action=review

> JSTests/wasm/function-tests/brTableAsIf.js:26
> +testWasmModuleFunctions(bin.get(), 1, [[{type: "i32", value: 22 }, [{ type: "i32", value: 0 }]],
> +                                       [{type: "i32", value: 20 }, [{ type: "i32", value: 1 }]],
> +                                       [{type: "i32", value: 20 }, [{ type: "i32", value: 11 }]],
> +                                       [{type: "i32", value: 20 }, [{ type: "i32", value: -100 }]]
> +                                      ]);

The indentation of these seems unnecessarily complicated. Why not use a more conventional approach?

    testWasmModuleFunctions(bin.get(), 1, [
        [{type: "i32", value: 22}, [{type: "i32", value: 0}]],
        [{type: "i32", value: 20}, [{type: "i32", value: 1}]],
        [{type: "i32", value: 20}, [{type: "i32", value: 11}]],
        [{type: "i32", value: 20}, [{type: "i32", value: -100}]]
    ]);

> JSTests/wasm/self-test/test_BuilderJSON.js:143
> +    assert.throws(() => i.Function("foo", "bar", 0), Error, `Shouldn't be undefined: Can not use type 0 if a type section is not present`);

"Can not" should probably be "Cannot".
And while this is eliminating contractions, the "Shouldn't" should be "Should not"!

[WebKit Commit Bot]

Comment on attachment 294571 [details]
Patch

Clearing flags on attachment: 294571

Committed r208634: <http://trac.webkit.org/changeset/208634>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.