Summary: run-safari does not appear to work for open source contributors. They end up having to use debug-safari. Either we should make run-safari work, or change the instructions <https://webkit.org/running-webkit/> > [16:19:45] Rik`: it seems run-safari is just using system webkit rather than the one I built > [16:20:48] dcrousso: oh yeah Rik` I have that issue too > [16:21:01] dcrousso: I have to use `debug-safari` instead > [16:21:17] dcrousso: followed by `r` or `run` > [16:21:31] dcrousso: ive been doing that for 2 years now > [16:22:34] Rik`: maybe we should update the instructions on https://webkit.org/running-webkit/ ? > [16:26:41] Rik`: I've found this info https://trac.webkit.org/wiki/WebKitNightlyElCapWorkaround but that didn't change things > [16:29:06] dcrousso: yeah ever since ElCapitan it hasnt been working It seems as though run-safari does launch SafariForWebKitDevelopment but is using System WebKit frameworks instead of the built WebKit frameworks.
<rdar://problem/29229894>
I can reproduce this in macOS Sierra 10.12.1. I can see that the “arch” branch is taken in webkitdirs.pm’s runWebKitApp(). If iI force the “system { $appPath }” code path to be taken, the right frameworks are picked up. I think this is due to arch(1) itself being restricted and therefore not carrying over DYLD_FRAMEWORK_PATH from the environment into what it’s executing. I think we have a workaround for that in one of the other scripts.
See <https://trac.webkit.org/r190412>, the fix for bug 149711, which was the same issue with run-api-tests.
Created attachment 294607 [details] Pass DYLD_* environment variables over arch(1)
Comment on attachment 294607 [details] Pass DYLD_* environment variables over arch(1) r=me! Thanks Dan!
Fixed in <https://trac.webkit.org/r208644>.
Comment on attachment 294607 [details] Pass DYLD_* environment variables over arch(1) View in context: https://bugs.webkit.org/attachment.cgi?id=294607&action=review > Tools/Scripts/run-api-tests:-391 > -sub archCommandLineArgumentsForRestrictedEnvironmentVariables() You may be able to remove a forward declaration for this at the top of this file. Now that it has moved.
Thanks, that fixed it!