Bug 164665 – RTCRtpTransceiver should have Ref of sender and receiver

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Currently it has RefPtr

[youenn fablet]

Created attachment 294577 [details]
Patch

[Build Bot]

Comment on attachment 294577 [details]
Patch

Attachment 294577 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2501212

New failing tests:
fast/mediastream/RTCPeerConnection-AddRemoveStream.html
fast/mediastream/RTCPeerConnection-onnegotiationneeded.html
fast/mediastream/RTCRtpSender-replaceTrack.html

[Build Bot]

Created attachment 294583 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[youenn fablet]

Created attachment 294617 [details]
Patch

[Darin Adler]

Comment on attachment 294617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294617&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:152
> +    for (RTCRtpSender& senderInSet : m_transceiverSet->senders()) {

I prefer auto& in a case like this.

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:397
> +    for (RTCRtpSender& sender : m_transceiverSet->senders())

Ditto.

[youenn fablet]

Thanks for the review.

(In reply to comment #5)
> Comment on attachment 294617 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=294617&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:152
> > +    for (RTCRtpSender& senderInSet : m_transceiverSet->senders()) {
> 
> I prefer auto& in a case like this.
> 
> > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:397
> > +    for (RTCRtpSender& sender : m_transceiverSet->senders())
> 
> Ditto.

I tried but it does not work unfortunately, senders are a vector of reference wrappers.

[WebKit Commit Bot]

Comment on attachment 294617 [details]
Patch

Clearing flags on attachment: 294617

Committed r208683: <http://trac.webkit.org/changeset/208683>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.