Bug 164632 - [DOMJIT] DOMJIT accessor attribute in IDL should say like DOMJIT=Getter
Summary: [DOMJIT] DOMJIT accessor attribute in IDL should say like DOMJIT=Getter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-10 21:52 PST by Yusuke Suzuki
Modified: 2016-11-10 23:45 PST (History)
11 users (show)

See Also:

Attachments
Patch (10.54 KB, patch)
2016-11-10 22:28 PST, Yusuke Suzuki 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-11-10 21:52:51 PST 
...
Comment 1 Yusuke Suzuki 2016-11-10 22:28:10 PST 
Created attachment 294474 [details]
Patch
Comment 2 Sam Weinig 2016-11-10 22:58:25 PST 
Comment on attachment 294474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294474&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1795
> +            die "Only DOMJIT=Getter is supported for attribute" unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter");

This would read slightly better if it said "Only DOMJIT=Getter is supported for attributes".  Also, I prefer using the assert() function rather than die, since it gives you a nice stack trace.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3407
> +                die "Only DOMJIT=Getter is supported for attribute" unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter");

Same.
Comment 3 Yusuke Suzuki 2016-11-10 23:30:59 PST 
Comment on attachment 294474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294474&action=review

Thanks!

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1795
>> +            die "Only DOMJIT=Getter is supported for attribute" unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter");
> 
> This would read slightly better if it said "Only DOMJIT=Getter is supported for attributes".  Also, I prefer using the assert() function rather than die, since it gives you a nice stack trace.

Oh, nice! Use assert and the above phrase.

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3407
>> +                die "Only DOMJIT=Getter is supported for attribute" unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter");
> 
> Same.

Fixed.
Comment 4 Yusuke Suzuki 2016-11-10 23:45:14 PST 
Committed r208582: <http://trac.webkit.org/changeset/208582>