164628 – JSC should distinguish between local and global eval

RESOLVED FIXED 164628

JSC should distinguish between local and global eval

https://bugs.webkit.org/show_bug.cgi?id=164628

Summary JSC should distinguish between local and global eval

Geoffrey Garen

Reported 2016-11-10 18:52:47 PST

JSC should distinguish between local and global eval

Attachments
Patch (63.64 KB, patch) 2016-11-10 19:04 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (63.72 KB, patch) 2016-11-11 08:59 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-yosemite (2.14 MB, application/zip) 2016-11-11 10:38 PST, Build Bot	no flags	Details
Patch (63.84 KB, patch) 2016-11-11 11:26 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (1.39 MB, application/zip) 2016-11-11 12:48 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.47 MB, application/zip) 2016-11-11 12:51 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (2.20 MB, application/zip) 2016-11-11 12:57 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (deleted) 2016-11-11 13:05 PST, Build Bot	no flags	Details
Patch (63.98 KB, patch) 2016-11-11 13:54 PST, Geoffrey Garen	saam: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2016-11-10 19:04:15 PST

Created attachment 294459 [details] Patch

Geoffrey Garen

Comment 2 2016-11-11 08:59:03 PST

Created attachment 294499 [details] Patch

Build Bot

Comment 3 2016-11-11 10:38:41 PST

Comment on attachment 294499 [details] Patch Attachment 294499 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2498653 New failing tests: http/tests/security/regress-52192.html html5lib/generated/run-tests18-data.html imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-setTimeout.html imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L.html html5lib/generated/run-tests1-write.html http/tests/security/cross-origin-script-window-onerror.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests18.html html5lib/generated/run-tests18-write.html imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-data-url.html html5lib/generated/run-tests7-write.html http/tests/security/cross-origin-script-error-event.html

Build Bot

Comment 4 2016-11-11 10:38:43 PST

Created attachment 294506 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Geoffrey Garen

Comment 5 2016-11-11 11:26:05 PST

Created attachment 294511 [details] Patch

Build Bot

Comment 6 2016-11-11 12:48:27 PST

Comment on attachment 294511 [details] Patch Attachment 294511 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2499216 New failing tests: html5lib/generated/run-tests18-write.html html5lib/generated/run-tests18-data.html imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L.html imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-setTimeout.html html5lib/generated/run-tests1-write.html http/tests/security/cross-origin-script-window-onerror.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests18.html http/tests/security/regress-52192.html imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-data-url.html html5lib/generated/run-tests7-write.html http/tests/security/cross-origin-script-error-event.html

Build Bot

Comment 7 2016-11-11 12:48:30 PST

Created attachment 294522 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-11-11 12:51:41 PST

Comment on attachment 294511 [details] Patch Attachment 294511 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2499221 New failing tests: html5lib/generated/run-tests18-write.html html5lib/generated/run-tests18-data.html imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L.html imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-setTimeout.html http/tests/security/cross-origin-script-window-onerror.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests18.html http/tests/security/regress-52192.html imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-data-url.html html5lib/generated/run-tests7-write.html http/tests/security/cross-origin-script-error-event.html

Build Bot

Comment 9 2016-11-11 12:51:44 PST

Created attachment 294523 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 10 2016-11-11 12:57:13 PST

Comment on attachment 294511 [details] Patch Attachment 294511 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2499231 New failing tests: html5lib/generated/run-tests18-write.html html5lib/generated/run-tests18-data.html imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L.html imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-setTimeout.html html5lib/generated/run-tests1-write.html http/tests/security/cross-origin-script-window-onerror.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests18.html http/tests/security/regress-52192.html html5lib/generated/run-tests7-write.html http/tests/security/cross-origin-script-error-event.html

Build Bot

Comment 11 2016-11-11 12:57:16 PST

Created attachment 294524 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 12 2016-11-11 13:05:43 PST

Comment on attachment 294511 [details] Patch Attachment 294511 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2499239 New failing tests: html5lib/generated/run-tests18-write.html html5lib/generated/run-tests18-data.html imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L.html imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-setTimeout.html html5lib/generated/run-tests1-write.html http/tests/security/cross-origin-script-window-onerror.html imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests18.html http/tests/security/regress-52192.html html5lib/generated/run-tests7-write.html http/tests/security/cross-origin-script-error-event.html

Build Bot

Comment 13 2016-11-11 13:05:46 PST

Created attachment 294525 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Geoffrey Garen

Comment 14 2016-11-11 13:54:16 PST

Created attachment 294529 [details] Patch

Saam Barati

Comment 15 2016-11-11 16:26:16 PST

Comment on attachment 294529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294529&action=review r=me > Source/JavaScriptCore/interpreter/Interpreter.cpp:134 > + auto* eval = callerCodeBlock->evalCodeCache().tryGet(programSource, callerCallSiteIndex); Style: I'm not a huge fan of auto here since to me it's not obvious what the type is. > Source/JavaScriptCore/runtime/GlobalEvalExecutable.cpp:2 > + * Copyright (C) 2009, 2010, 2013, 2015-2016 Apple Inc. All rights reserved. should just be 2016? > Source/JavaScriptCore/runtime/GlobalEvalExecutable.h:2 > + * Copyright (C) 2009, 2010, 2013-2016 Apple Inc. All rights reserved. should just be 2016? > Source/JavaScriptCore/runtime/LocalEvalExecutable.cpp:2 > + * Copyright (C) 2009, 2010, 2013, 2015-2016 Apple Inc. All rights reserved. ditto > Source/JavaScriptCore/runtime/LocalEvalExecutable.h:2 > + * Copyright (C) 2009, 2010, 2013-2016 Apple Inc. All rights reserved. ditto

Geoffrey Garen

Comment 16 2016-11-14 15:00:22 PST

Committed r208712: <http://trac.webkit.org/changeset/208712>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Geoffrey Garen

Reported

2016-11-10 18:52 PST

Modified

2016-11-14 15:00 PST History

CC List

2 users Show

URL

Keywords

Depends on

Blocks