[SVG] Start moving special casing of SVG out of the bindings - SVGPreserveAspectRatio
Created attachment 294431 [details] Patch
Attachment 294431 [details] did not pass style-queue: ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.cpp:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:35: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:49: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:50: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:51: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 15 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 294464 [details] Patch
Attachment 294464 [details] did not pass style-queue: ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.cpp:119: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:35: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:37: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:38: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:49: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:50: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/svg/SVGPreserveAspectRatioValue.h:51: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 15 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 294464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294464&action=review Some comments on moved code. > Source/WebCore/svg/SVGPreserveAspectRatioValue.cpp:188 > + case SVGPreserveAspectRatio::SVG_MEETORSLICE_UNKNOWN: No need to repeat the class name here since this is inside a member function of that class. Same for all the other cases below. > Source/WebCore/svg/SVGPreserveAspectRatioValue.cpp:273 > +AffineTransform SVGPreserveAspectRatio::getCTM(float logicalX, float logicalY, float logicalWidth, float logicalHeight, float physicalWidth, float physicalHeight) const Strange that this passes all the arguments as separate floats rather than FloatSize and FloatRect. > Source/WebCore/svg/SVGPreserveAspectRatioValue.cpp:291 > + double extendedLogicalX = logicalX; > + double extendedLogicalY = logicalY; > + double extendedLogicalWidth = logicalWidth; > + double extendedLogicalHeight = logicalHeight; > + double extendedPhysicalWidth = physicalWidth; > + double extendedPhysicalHeight = physicalHeight; > + double logicalRatio = extendedLogicalWidth / extendedLogicalHeight; > + double physicalRatio = extendedPhysicalWidth / extendedPhysicalHeight; A bit peculiar to mix float and double like this. > Source/WebCore/svg/SVGPreserveAspectRatioValue.cpp:330 > + alignType = "none"; ASCIILiteral?
Comment on attachment 294464 [details] Patch Clearing flags on attachment: 294464 Committed r208581: <http://trac.webkit.org/changeset/208581>
All reviewed patches have been landed. Closing bug.