Bug 164619 - [Modern Media Controls] UI Library: <audio> controls
Summary: [Modern Media Controls] UI Library: <audio> controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari 10
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-10 14:26 PST by Antoine Quint
Modified: 2016-11-30 16:15 PST (History)
4 users (show)

See Also:


Attachments
Patch (10.93 KB, patch)
2016-11-10 14:30 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (1.35 MB, application/zip)
2016-11-10 15:22 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.57 MB, application/zip)
2016-11-10 15:28 PST, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (16.15 MB, application/zip)
2016-11-10 16:04 PST, Build Bot
no flags Details
Archive of layout-test-results from ews117 for mac-yosemite (1.95 MB, application/zip)
2016-11-10 16:17 PST, Build Bot
no flags Details
Patch (10.91 KB, patch)
2016-11-11 01:54 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (806.83 KB, application/zip)
2016-11-11 02:55 PST, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (928.58 KB, application/zip)
2016-11-11 03:03 PST, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.83 MB, application/zip)
2016-11-11 03:05 PST, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (deleted)
2016-11-11 03:13 PST, Build Bot
no flags Details
Patch (12.87 KB, patch)
2016-11-11 05:36 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (941.37 KB, application/zip)
2016-11-11 06:34 PST, Build Bot
no flags Details
Patch (19.75 KB, patch)
2016-11-30 14:35 PST, Antoine Quint
dino: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (916.39 KB, application/zip)
2016-11-30 15:55 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-11-10 14:26:31 PST
We need to update the default size of <audio> controls to be 50px tall. We will support shorter heights in a followup patch where we will switch to a condensed layout.
Comment 1 Radar WebKit Bug Importer 2016-11-10 14:29:23 PST
<rdar://problem/29207215>
Comment 2 Antoine Quint 2016-11-10 14:30:30 PST
Created attachment 294416 [details]
Patch
Comment 3 Build Bot 2016-11-10 15:22:45 PST
Comment on attachment 294416 [details]
Patch

Attachment 294416 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2493264

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
Comment 4 Build Bot 2016-11-10 15:22:48 PST
Created attachment 294421 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-11-10 15:28:32 PST
Comment on attachment 294416 [details]
Patch

Attachment 294416 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2493270

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
Comment 6 Build Bot 2016-11-10 15:28:34 PST
Created attachment 294422 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-11-10 16:04:50 PST
Comment on attachment 294416 [details]
Patch

Attachment 294416 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2493355

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/modern-media-controls/audio/audio-controls-metrics.html
Comment 8 Build Bot 2016-11-10 16:04:53 PST
Created attachment 294432 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2016-11-10 16:17:17 PST
Comment on attachment 294416 [details]
Patch

Attachment 294416 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2493416

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
Comment 10 Build Bot 2016-11-10 16:17:20 PST
Created attachment 294436 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Antoine Quint 2016-11-11 01:54:56 PST
Created attachment 294486 [details]
Patch
Comment 12 Build Bot 2016-11-11 02:55:54 PST
Comment on attachment 294486 [details]
Patch

Attachment 294486 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2497118

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
Comment 13 Build Bot 2016-11-11 02:55:57 PST
Created attachment 294490 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 14 Build Bot 2016-11-11 03:03:29 PST
Comment on attachment 294486 [details]
Patch

Attachment 294486 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2497128

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
Comment 15 Build Bot 2016-11-11 03:03:32 PST
Created attachment 294491 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 16 Build Bot 2016-11-11 03:05:28 PST
Comment on attachment 294486 [details]
Patch

Attachment 294486 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2497126

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
Comment 17 Build Bot 2016-11-11 03:05:32 PST
Created attachment 294492 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 18 Build Bot 2016-11-11 03:13:36 PST
Comment on attachment 294486 [details]
Patch

Attachment 294486 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2497130

New failing tests:
media/modern-media-controls/audio/audio-controls-buttons.html
media/modern-media-controls/audio/audio-controls-metrics.html
Comment 19 Build Bot 2016-11-11 03:13:39 PST
Created attachment 294493 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 20 Antoine Quint 2016-11-11 05:36:06 PST
Created attachment 294495 [details]
Patch
Comment 21 Build Bot 2016-11-11 06:34:44 PST
Comment on attachment 294495 [details]
Patch

Attachment 294495 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2497910

New failing tests:
media/modern-media-controls/audio/audio-controls-metrics.html
Comment 22 Build Bot 2016-11-11 06:34:47 PST
Created attachment 294496 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 23 Antoine Quint 2016-11-30 14:35:13 PST
Created attachment 295771 [details]
Patch
Comment 24 Dean Jackson 2016-11-30 15:24:04 PST
Comment on attachment 295771 [details]
Patch

Why isn't this two patches?
Comment 25 Build Bot 2016-11-30 15:55:03 PST
Comment on attachment 295771 [details]
Patch

Attachment 295771 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2597751

New failing tests:
media/modern-media-controls/audio/audio-controls-metrics.html
Comment 26 Build Bot 2016-11-30 15:55:08 PST
Created attachment 295779 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 27 Antoine Quint 2016-11-30 16:15:42 PST
https://trac.webkit.org/changeset/209163