Bug 164614 - [Win][Direct2D] Add transparency layer support
Summary: [Win][Direct2D] Add transparency layer support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-10 13:51 PST by Brent Fulgham
Modified: 2016-11-10 17:02 PST (History)
4 users (show)

See Also:

Attachments
Patch (12.73 KB, patch)
2016-11-10 14:01 PST, Brent Fulgham 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-11-10 13:51:49 PST 
The initial D2D implementation did not properly support the begin/end transparency layer logic, causing tests like 'fast/layers/opacity-stacking.html' to fail.
Comment 1 Brent Fulgham 2016-11-10 14:01:19 PST 
Created attachment 294411 [details]
Patch
Comment 2 Dean Jackson 2016-11-10 16:57:11 PST 
Comment on attachment 294411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294411&action=review

> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:513
>      float colorAlpha = color.alpha() / 255.0f;

Please change this to color.alphaAsFloat()
Comment 3 Brent Fulgham 2016-11-10 17:01:47 PST 
Comment on attachment 294411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294411&action=review

>> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:513
>>      float colorAlpha = color.alpha() / 255.0f;
> 
> Please change this to color.alphaAsFloat()

Done!
Comment 4 Brent Fulgham 2016-11-10 17:02:59 PST 
Committed r208573: <http://trac.webkit.org/changeset/208573>