WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
164614
[Win][Direct2D] Add transparency layer support
https://bugs.webkit.org/show_bug.cgi?id=164614
Summary
[Win][Direct2D] Add transparency layer support
Brent Fulgham
Reported
2016-11-10 13:51:49 PST
The initial D2D implementation did not properly support the begin/end transparency layer logic, causing tests like 'fast/layers/opacity-stacking.html' to fail.
Attachments
Patch
(12.73 KB, patch)
2016-11-10 14:01 PST
,
Brent Fulgham
dino
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2016-11-10 14:01:19 PST
Created
attachment 294411
[details]
Patch
Dean Jackson
Comment 2
2016-11-10 16:57:11 PST
Comment on
attachment 294411
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=294411&action=review
> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:513 > float colorAlpha = color.alpha() / 255.0f;
Please change this to color.alphaAsFloat()
Brent Fulgham
Comment 3
2016-11-10 17:01:47 PST
Comment on
attachment 294411
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=294411&action=review
>> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:513 >> float colorAlpha = color.alpha() / 255.0f; > > Please change this to color.alphaAsFloat()
Done!
Brent Fulgham
Comment 4
2016-11-10 17:02:59 PST
Committed
r208573
: <
http://trac.webkit.org/changeset/208573
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug