Bug 164605 - Incorrect release log message emitted when waiting/not waiting for the WebProcess continue a load
Summary: Incorrect release log message emitted when waiting/not waiting for the WebPro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-10 11:51 PST by Daniel Bates
Modified: 2016-11-12 21:53 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2016-11-10 11:52 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-11-10 11:51:31 PST 
Currently the release log messages emitted in NetworkResourceLoader::didReceiveResponse() are inverted with respect to whether we are waiting for the WebProcess to send message NetworkResourceLoader::ContinueDidReceiveResponse. We emit a release log message of the form "didReceiveResponse: Should wait for message from WebContent process ..." when we are not waiting for the WebProcess and emit a message of the form "didReceiveResponse: Should not wait for message from WebContent process" when we are waiting on the WebProcess. We should invert these messages.
Comment 1 Daniel Bates 2016-11-10 11:52:45 PST 
Created attachment 294393 [details]
Patch
Comment 2 WebKit Commit Bot 2016-11-12 21:53:40 PST 
Comment on attachment 294393 [details]
Patch

Clearing flags on attachment: 294393

Committed r208665: <http://trac.webkit.org/changeset/208665>
Comment 3 WebKit Commit Bot 2016-11-12 21:53:44 PST 
All reviewed patches have been landed.  Closing bug.