Bug 164581 - [JSC] op_in should have ArrayProfile
Summary: [JSC] op_in should have ArrayProfile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-09 23:35 PST by Yusuke Suzuki
Modified: 2017-02-08 16:03 PST (History)
8 users (show)

See Also:

Attachments
Patch (27.57 KB, patch)
2017-02-08 12:15 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (27.60 KB, patch)
2017-02-08 13:36 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-11-09 23:35:29 PST 
Much time is taken in Array.prototype.map in ES6SampleBench/Basic.
And sampling profiler tells us that op_in is one of the hottest bytecode.
We have a path optimizing `"string" in obj` case, but we always fall into the slow generic code for `index in array` case.

We should have array profile and handle op_in like GetByVal thing.
Comment 1 Keith Miller 2017-02-08 12:15:59 PST 
Created attachment 300935 [details]
Patch
Comment 2 Keith Miller 2017-02-08 13:36:41 PST 
Created attachment 300954 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2017-02-08 16:03:53 PST 
Comment on attachment 300954 [details]
Patch for landing

Clearing flags on attachment: 300954

Committed r211908: <http://trac.webkit.org/changeset/211908>
Comment 4 WebKit Commit Bot 2017-02-08 16:03:57 PST 
All reviewed patches have been landed.  Closing bug.