Bug 164571 – LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r208491%20(9320)/results.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-actual.txt
@@ -8,8 +8,14 @@
 PASS mediaController.controls.height is 240
 
 Resizing to 400x300
-PASS mediaController.controls.width is 400
-PASS mediaController.controls.height is 300
+FAIL mediaController.controls.width should be 400. Was 320.
+FAIL mediaController.controls.height should be 300. Was 240.
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+FAIL mediaController.controls.width should be 400. Was 0.
+FAIL mediaController.controls.height should be 300. Was 0.
 
 PASS successfullyParsed is true

[Ryan Haddad]

Marked as flaky (or rather, added failure to the list) in http://trac.webkit.org/projects/webkit/changeset/208512

[Ryan Haddad]

Flaky expectation was removed as part of http://trac.webkit.org/projects/webkit/changeset/209291, but the test is still a flaky failure.

[Ryan Haddad]

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r209315%20(10107)/media/modern-media-controls/media-controller/media-controller-resize-diff.txt

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-actual.txt
@@ -4,14 +4,14 @@
 
 
 Checking initial size
-PASS mediaControls.style.width is "320px"
-PASS mediaControls.style.height is "240px"
+FAIL mediaControls.style.width should be 320px. Was .
+FAIL mediaControls.style.height should be 240px. Was .
 
 Resizing to 400x300
 
 Shadow root received a resize event
-PASS mediaControls.style.width is "400px"
-PASS mediaControls.style.height is "300px"
+FAIL mediaControls.style.width should be 400px. Was .
+FAIL mediaControls.style.height should be 300px. Was .
 
 PASS successfullyParsed is true

[Ryan Haddad]

Marked as flaky again in http://trac.webkit.org/projects/webkit/changeset/209323

[Ryan Haddad]

(In reply to comment #4)
> Marked as flaky again in
> http://trac.webkit.org/projects/webkit/changeset/209323

Once more in https://trac.webkit.org/r211090

[Antoine Quint]

This hasn't been flaky on Apple bots for 3 days.

[Antoine Quint]

Marked as flaky on Debug El Capitan only in http://trac.webkit.org/changeset/211423.

[Antoine Quint]

Created attachment 300400 [details]
Patch

[Antoine Quint]

Created attachment 300401 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 300401 [details]
Patch for landing

Clearing flags on attachment: 300401

Committed r211557: <http://trac.webkit.org/changeset/211557>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.