Bug 164571 - LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure
Summary: LayoutTest media/modern-media-controls/media-controller/media-controller-resi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks: 164784
  Show dependency tree / graph
 
Reported: 2016-11-09 17:00 PST by Ryan Haddad
Modified: 2017-02-02 06:27 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2017-02-02 05:23 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (1.57 KB, patch)
2017-02-02 05:25 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-11-09 17:00:57 PST 
LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r208491%20(9320)/results.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-actual.txt
@@ -8,8 +8,14 @@
 PASS mediaController.controls.height is 240
 
 Resizing to 400x300
-PASS mediaController.controls.width is 400
-PASS mediaController.controls.height is 300
+FAIL mediaController.controls.width should be 400. Was 320.
+FAIL mediaController.controls.height should be 300. Was 240.
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+FAIL mediaController.controls.width should be 400. Was 0.
+FAIL mediaController.controls.height should be 300. Was 0.
 
 PASS successfullyParsed is true
Comment 1 Ryan Haddad 2016-11-09 17:25:11 PST 
Marked as flaky (or rather, added failure to the list) in http://trac.webkit.org/projects/webkit/changeset/208512
Comment 2 Ryan Haddad 2016-12-05 09:47:44 PST 
Flaky expectation was removed as part of http://trac.webkit.org/projects/webkit/changeset/209291, but the test is still a flaky failure.
Comment 3 Ryan Haddad 2016-12-05 09:50:47 PST 
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r209315%20(10107)/media/modern-media-controls/media-controller/media-controller-resize-diff.txt

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-resize-actual.txt
@@ -4,14 +4,14 @@
 
 
 Checking initial size
-PASS mediaControls.style.width is "320px"
-PASS mediaControls.style.height is "240px"
+FAIL mediaControls.style.width should be 320px. Was .
+FAIL mediaControls.style.height should be 240px. Was .
 
 Resizing to 400x300
 
 Shadow root received a resize event
-PASS mediaControls.style.width is "400px"
-PASS mediaControls.style.height is "300px"
+FAIL mediaControls.style.width should be 400px. Was .
+FAIL mediaControls.style.height should be 300px. Was .
 
 PASS successfullyParsed is true
Comment 4 Ryan Haddad 2016-12-05 09:51:23 PST 
Marked as flaky again in http://trac.webkit.org/projects/webkit/changeset/209323
Comment 5 Ryan Haddad 2017-01-24 10:29:17 PST 
(In reply to comment #4)
> Marked as flaky again in
> http://trac.webkit.org/projects/webkit/changeset/209323

Once more in https://trac.webkit.org/r211090
Comment 6 Antoine Quint 2017-01-30 12:01:54 PST 
This hasn't been flaky on Apple bots for 3 days.
Comment 7 Antoine Quint 2017-01-31 02:59:31 PST 
Marked as flaky on Debug El Capitan only in http://trac.webkit.org/changeset/211423.
Comment 8 Antoine Quint 2017-02-02 05:23:53 PST 
Created attachment 300400 [details]
Patch
Comment 9 Antoine Quint 2017-02-02 05:25:44 PST 
Created attachment 300401 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2017-02-02 06:27:48 PST 
Comment on attachment 300401 [details]
Patch for landing

Clearing flags on attachment: 300401

Committed r211557: <http://trac.webkit.org/changeset/211557>
Comment 11 WebKit Commit Bot 2017-02-02 06:27:52 PST 
All reviewed patches have been landed.  Closing bug.