LayoutTest fast/loader/reload-zero-byte-plugin.html is failing https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r208504%20(1288)/results.html --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/fast/loader/reload-zero-byte-plugin-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/fast/loader/reload-zero-byte-plugin-actual.txt @@ -1 +1,4 @@ +Download started. +Downloading URL with suggested filename "Unknown" +Download completed. This test passes if it doesn't crash. To run manually, please disable your popup blocker.
Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/208553
Hmm, a similar diff with imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video.html https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r208550%20(19346)/results.html
I think this may be somehow related to http://trac.webkit.org/changeset/208522 The test fast/dom/HTMLAnchorElement/anchor-file-blob-download.html expects some of the text seen in the diffs above. https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-expected.txt?rev=208522
Similar failure here with http/tests/loading/text-content-type-with-binary-extension.html https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r208562%20(19351)/results.html
(In reply to comment #3) > I think this may be somehow related to > http://trac.webkit.org/changeset/208522 > > The test fast/dom/HTMLAnchorElement/anchor-file-blob-download.html expects > some of the text seen in the diffs above. > > https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/ > anchor-file-blob-download-expected.txt?rev=208522 Actually, since the filename is "Unknown", this is unlikely to be https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/ > anchor-file-blob-download-expected.txt. $ git grep "Downloading URL with suggested filename" LayoutTests/ | grep nknown LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-expected.txt:Downloading URL with suggested filename "unknown" LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click-expected.txt:Downloading URL with suggested filename "unknown" LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-expected.txt:Downloading URL with suggested filename "unknown" LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt:Downloading URL with suggested filename "unknown" Interestingly though, they all expect "unknown" with a lowercase "u" but the flaky test has "Unknown" with a capital "U".
(In reply to comment #5) > (In reply to comment #3) > > I think this may be somehow related to > > http://trac.webkit.org/changeset/208522 > > > > The test fast/dom/HTMLAnchorElement/anchor-file-blob-download.html expects > > some of the text seen in the diffs above. > > > > https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/ > > anchor-file-blob-download-expected.txt?rev=208522 > > Actually, since the filename is "Unknown", this is unlikely to be > https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/ > > anchor-file-blob-download-expected.txt. > > $ git grep "Downloading URL with suggested filename" LayoutTests/ | grep > nknown > LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-expected.txt: > Downloading URL with suggested filename "unknown" > LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-user-triggered- > synthetic-click-expected.txt:Downloading URL with suggested filename > "unknown" > LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download- > expected.txt:Downloading URL with suggested filename "unknown" > LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: > Downloading URL with suggested filename "unknown" > > Interestingly though, they all expect "unknown" with a lowercase "u" but the > flaky test has "Unknown" with a capital "U". LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html uses: testRunner.setShouldDownloadUndisplayableMIMETypes(true); Maybe this does not get reset properly between tests and it causes the next test to download.
Created attachment 294429 [details] Patch
Committed r208569: <http://trac.webkit.org/changeset/208569>