RESOLVED FIXED 164569
jsc CLI should work with the remote inspector 
https://bugs.webkit.org/show_bug.cgi?id=164569
Summary jsc CLI should work with the remote inspector
Keith Miller
Reported 2016-11-09 16:53:41 PST
jsc CLI should work with the remote inspector
Attachments
Patch (3.32 KB, patch)
2016-11-09 17:14 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (3.32 KB, patch)
2016-11-09 17:15 PST, Keith Miller 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-11-09 17:14:11 PST
Created attachment 294309 [details] Patch
Michael Saboff
Comment 2 2016-11-09 17:15:41 PST
Comment on attachment 294309 [details] Patch r=me
Keith Miller
Comment 3 2016-11-09 17:15:46 PST
Created attachment 294310 [details] Patch
Joseph Pecoraro
Comment 4 2016-11-09 17:20:15 PST
Comment on attachment 294310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294310&action=review r=me > Source/JavaScriptCore/inspector/InjectedScriptBase.cpp:-88 > - ASSERT(!hadException); We shouldn't check this in. We hate the assert, but it does catch real exceptions that we (Inspector folks) should investigate. > Source/JavaScriptCore/jsc.cpp:2785 > + if (!strcmp(arg, "--remote-debug")) { Might want to add this to the --help usage.
Keith Miller
Comment 5 2016-11-09 17:25:19 PST
Committed r208514: <http://trac.webkit.org/changeset/208514>
Note You need to log in before you can comment on or make changes to this bug.