Bug 164562 - Clean up Storage code
Summary: Clean up Storage code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-09 15:03 PST by Alex Christensen
Modified: 2016-11-09 15:31 PST (History)
1 user (show)

See Also:

Attachments
Patch (54.48 KB, patch)
2016-11-09 15:04 PST, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-11-09 15:03:15 PST 
Clean up Storage code
Comment 1 Alex Christensen 2016-11-09 15:04:39 PST 
Created attachment 294296 [details]
Patch
Comment 2 Brady Eidson 2016-11-09 15:18:48 PST 
Comment on attachment 294296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294296&action=review

> Source/WebKit2/ChangeLog:3
> +        Clean up Storage code

This patch doesn't appear to be exclusively related to doing... this.

> Source/WebKit2/Platform/IPC/HandleMessage.h:3
> +/*
> + * Copyright (C) 2016 Apple Inc. All rights reserved.
> + *

A long used .h file without a header! Wow!

Please put in all the copyright dates where Apple has touched it. (assuming it's not new this year)

> Source/WebKit2/Platform/IPC/HandleMessage.h:82
>  void callMemberFunctionImpl(C* object, MF function, Connection& connection, ArgsTuple&& args, std::index_sequence<ArgsIndex...>)
>  {
> -    (object->*function)(connection, std::get<ArgsIndex>(args)...);
> +    (object->*function)(connection, std::get<ArgsIndex>(std::forward<ArgsTuple>(args))...);

Apparently this is for a future patch.

Please do it in the future patch.

> Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.h:26
> +#pragma once

👍

> Source/WebKit/Storage/StorageAreaImpl.h:26
> +#pragma once

👍
Comment 3 Alex Christensen 2016-11-09 15:31:29 PST 
http://trac.webkit.org/changeset/208499