Bug 164554 – [Modern Media Controls] Media Controller: update controls based on fullscreen playback on macOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

Now that we have the logic in place to enter fullscreen and to display fullscreen controls, we need to correctly toggle between fullscreen and inline controls on macOS.

[Radar WebKit Bug Importer]

<rdar://problem/29183439>

[Antoine Quint]

Created attachment 294260 [details]
Patch

[Dean Jackson]

Comment on attachment 294260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294260&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:44
> +        let traits = window.navigator.platform === "MacIntel" ? LayoutTraits.macOS : LayoutTraits.iOS;

uuugh.... is there any way we can do this better?

[Build Bot]

Comment on attachment 294260 [details]
Patch

Attachment 294260 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2484905

New failing tests:
media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

[Build Bot]

Created attachment 294273 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294260 [details]
Patch

Attachment 294260 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2485013

New failing tests:
media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

[Build Bot]

Created attachment 294274 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294260 [details]
Patch

Attachment 294260 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2485693

New failing tests:
media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

[Build Bot]

Created attachment 294298 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antoine Quint]

Created attachment 294344 [details]
Patch

[Build Bot]

Comment on attachment 294344 [details]
Patch

Attachment 294344 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2488176

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 294351 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294344 [details]
Patch

Attachment 294344 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2488240

New failing tests:
media/modern-media-controls/start-support/start-support-no-source.html
media/modern-media-controls/volume-support/volume-support-media-api.html
media/modern-media-controls/media-controller/media-controller-fullscreen-change.html
media/modern-media-controls/volume-support/volume-support-media-api-mute.html
media/modern-media-controls/playback-support/playback-support-autoplay.html
http/tests/media/modern-media-controls/status-support/status-support-live-broadcast.html
media/modern-media-controls/start-support/start-support-error.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/scrubber-support/scrubber-support-media-api.html
media/modern-media-controls/remaining-time-support/remaining-time-support.html
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
media/modern-media-controls/mute-support/mute-support-muted.html
media/modern-media-controls/start-support/start-support-autoplay.html
media/modern-media-controls/start-support/start-support-audio.html
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html
media/modern-media-controls/status-support/status-support-error.html
media/modern-media-controls/media-controller/media-controller-constructor.html
media/modern-media-controls/mute-support/mute-support-media-api.html
http/tests/media/modern-media-controls/status-support/status-support-loading.html
media/modern-media-controls/mute-support/mute-support-button-click.html
media/modern-media-controls/playback-support/playback-support-media-api.html
media/modern-media-controls/fullscreen-support/fullscreen-support-click.html
media/modern-media-controls/start-support/start-support-manual-play.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/elapsed-time-support/elapsed-time-support.html

[Build Bot]

Created attachment 294352 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antoine Quint]

Created attachment 294353 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 294353 [details]
Patch

Clearing flags on attachment: 294353

Committed r208537: <http://trac.webkit.org/changeset/208537>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.