Bug 164552 - Add test that image load over default port using HTTP 0.9 protocol is blocked when page is served with a different HTTP version
Summary: Add test that image load over default port using HTTP 0.9 protocol is blocked...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-09 11:11 PST by Daniel Bates
Modified: 2016-11-10 11:00 PST (History)
6 users (show)

See Also:


Attachments
Layout test (2.18 KB, patch)
2016-11-09 11:13 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (917.91 KB, application/zip)
2016-11-09 12:16 PST, Build Bot
no flags Details
Archive of layout-test-results from ews103 for mac-yosemite (1.17 MB, application/zip)
2016-11-09 12:33 PST, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (12.74 MB, application/zip)
2016-11-09 12:38 PST, Build Bot
no flags Details
Layout test (2.09 KB, patch)
2016-11-09 14:17 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-11-09 11:11:47 PST
Currently we block an image served over a default HTTP/HTTPS port using the HTTP 0.9 protocol when the embedding page used a different HTTP version. We should add a test for this.
Comment 1 Daniel Bates 2016-11-09 11:13:35 PST
Created attachment 294251 [details]
Layout test
Comment 2 Build Bot 2016-11-09 12:16:39 PST
Comment on attachment 294251 [details]
Layout test

Attachment 294251 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2484615

New failing tests:
http/tests/security/http-0.9/image-default-port-blocked.html
Comment 3 Build Bot 2016-11-09 12:16:42 PST
Created attachment 294264 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-11-09 12:33:06 PST
Comment on attachment 294251 [details]
Layout test

Attachment 294251 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2484716

New failing tests:
http/tests/security/http-0.9/image-default-port-blocked.html
Comment 5 Build Bot 2016-11-09 12:33:09 PST
Created attachment 294266 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-11-09 12:38:07 PST
Comment on attachment 294251 [details]
Layout test

Attachment 294251 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2484631

New failing tests:
http/tests/security/http-0.9/image-default-port-blocked.html
Comment 7 Build Bot 2016-11-09 12:38:11 PST
Created attachment 294267 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 8 Brent Fulgham 2016-11-09 13:32:12 PST
Are these tests failing because this patch depends on Bug 164389?
Comment 9 Daniel Bates 2016-11-09 14:17:16 PST
Created attachment 294289 [details]
Layout test
Comment 10 Brent Fulgham 2016-11-09 14:48:38 PST
Comment on attachment 294289 [details]
Layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=294289&action=review

r=me.

> LayoutTests/ChangeLog:4
> +        served with a different HTTP version

Good idea to guard against this.
Comment 11 Daniel Bates 2016-11-10 11:00:01 PST
Comment on attachment 294289 [details]
Layout test

Clearing flags on attachment: 294289

Committed r208551: <http://trac.webkit.org/changeset/208551>
Comment 12 Daniel Bates 2016-11-10 11:00:05 PST
All reviewed patches have been landed.  Closing bug.