Bug 164550 - Cleanup: Remove redundant logic to cancel document load for HTTP 0.9 request
Summary: Cleanup: Remove redundant logic to cancel document load for HTTP 0.9 request
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-09 11:04 PST by Daniel Bates
Modified: 2016-11-11 12:09 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.14 KB, patch)
2016-11-09 11:06 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-11-09 11:04:15 PST 
Currently both DocumentLoader and ResourceLoader have logic to stop a load when the HTTP response is using the 0.9 protocol. It is unnecessary to have such logic in DocumentLoader because DocumentLoader derives from ResourceLoader and ResourceLoader knows to stop loading for an HTTP 0.9 response.
Comment 1 Daniel Bates 2016-11-09 11:06:00 PST 
Created attachment 294244 [details]
Patch
Comment 2 Brent Fulgham 2016-11-09 16:18:31 PST 
Comment on attachment 294244 [details]
Patch

It looks like this patch depends on one of your earlier patches. Could you rebaseline after you land the necessary changes?
Comment 3 Brent Fulgham 2016-11-09 16:19:47 PST 
Comment on attachment 294244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294244&action=review

> Source/WebCore/loader/DocumentLoader.cpp:-744
> -

I am sad that I created this redundancy to begin with. Thank you for fixing this!
Comment 4 Brent Fulgham 2016-11-09 16:20:38 PST 
I think this patch looks good, but I don't want to r+ it without a successful EWS run. Could you please re-upload the patch after the dependent changes land?
Comment 5 Daniel Bates 2016-11-11 12:09:09 PST 
This patch is not necessary. We need to move the HTTP 0.9 blocking machinery to ResourceHandle/NetworkLoad to ensure that the machinery applies to all loads.