RESOLVED INVALID 164550
Cleanup: Remove redundant logic to cancel document load for HTTP 0.9 request 
https://bugs.webkit.org/show_bug.cgi?id=164550
Summary Cleanup: Remove redundant logic to cancel document load for HTTP 0.9 request
Daniel Bates
Reported 2016-11-09 11:04:15 PST
Currently both DocumentLoader and ResourceLoader have logic to stop a load when the HTTP response is using the 0.9 protocol. It is unnecessary to have such logic in DocumentLoader because DocumentLoader derives from ResourceLoader and ResourceLoader knows to stop loading for an HTTP 0.9 response.
Attachments
Patch (6.14 KB, patch)
2016-11-09 11:06 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-11-09 11:06:00 PST
Created attachment 294244 [details] Patch
Brent Fulgham
Comment 2 2016-11-09 16:18:31 PST
Comment on attachment 294244 [details] Patch It looks like this patch depends on one of your earlier patches. Could you rebaseline after you land the necessary changes?
Brent Fulgham
Comment 3 2016-11-09 16:19:47 PST
Comment on attachment 294244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294244&action=review > Source/WebCore/loader/DocumentLoader.cpp:-744 > - I am sad that I created this redundancy to begin with. Thank you for fixing this!
Brent Fulgham
Comment 4 2016-11-09 16:20:38 PST
I think this patch looks good, but I don't want to r+ it without a successful EWS run. Could you please re-upload the patch after the dependent changes land?
Daniel Bates
Comment 5 2016-11-11 12:09:09 PST
This patch is not necessary. We need to move the HTTP 0.9 blocking machinery to ResourceHandle/NetworkLoad to ensure that the machinery applies to all loads.
Note You need to log in before you can comment on or make changes to this bug.