Bug 164532 - [WK2] Network cache speculative revalidation can cause loads to hang
Summary: [WK2] Network cache speculative revalidation can cause loads to hang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-08 15:53 PST by Chris Dumez
Modified: 2016-11-09 10:09 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.79 KB, patch)
2016-11-08 16:05 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.84 KB, patch)
2016-11-08 16:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-11-08 15:53:26 PST 
Network cache speculative revalidation can cause loads to hang when HTTP authentication is used.
Comment 1 Chris Dumez 2016-11-08 15:53:45 PST 
<rdar://problem/28519331>
Comment 2 Chris Dumez 2016-11-08 16:05:30 PST 
Created attachment 294199 [details]
Patch
Comment 3 Alex Christensen 2016-11-08 16:43:49 PST 
Comment on attachment 294199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294199&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:118
> +void SpeculativeLoad::canAuthenticateAgainstProtectionSpaceAsync(const WebCore::ProtectionSpace&)

#if USE(PROTECTION_SPACE_AUTH_CALLBACK) around this
Comment 4 Chris Dumez 2016-11-08 16:53:07 PST 
Created attachment 294201 [details]
Patch
Comment 5 Chris Dumez 2016-11-09 10:09:32 PST 
Comment on attachment 294201 [details]
Patch

Clearing flags on attachment: 294201

Committed r208437: <http://trac.webkit.org/changeset/208437>
Comment 6 Chris Dumez 2016-11-09 10:09:36 PST 
All reviewed patches have been landed.  Closing bug.