WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
164525
[WebGL2] Teach WebGLRenderingContextBase about new texture internal formats
https://bugs.webkit.org/show_bug.cgi?id=164525
Summary
[WebGL2] Teach WebGLRenderingContextBase about new texture internal formats
Myles C. Maxfield
Reported
2016-11-08 14:28:31 PST
[WebGL2] Teach WebGLRenderingContextBase about new texture internal formats
Attachments
WIP
(25.37 KB, patch)
2016-11-08 14:31 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(54.26 KB, patch)
2016-11-08 19:16 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(132.71 KB, patch)
2016-11-09 00:31 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(151.36 KB, patch)
2016-11-09 13:24 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(151.38 KB, patch)
2016-11-09 13:44 PST
,
Myles C. Maxfield
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews102 for mac-yosemite
(1.16 MB, application/zip)
2016-11-09 14:45 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2
(1.43 MB, application/zip)
2016-11-09 14:52 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews116 for mac-yosemite
(1.75 MB, application/zip)
2016-11-09 16:52 PST
,
Build Bot
no flags
Details
WIP
(159.55 KB, patch)
2016-11-09 18:09 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(239.82 KB, patch)
2016-11-10 01:23 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(248.62 KB, patch)
2016-11-10 11:48 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(250.28 KB, patch)
2016-11-10 11:59 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(258.06 KB, patch)
2016-11-10 13:46 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(258.36 KB, patch)
2016-11-10 14:43 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(258.41 KB, patch)
2016-11-10 15:45 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
WIP
(265.32 KB, patch)
2016-11-11 15:29 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
Patch
(256.09 KB, patch)
2016-11-11 16:16 PST
,
Myles C. Maxfield
dino
: review+
Details
Formatted Diff
Diff
Patch
(259.67 KB, patch)
2016-11-11 16:34 PST
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
Patch for committing
(254.10 KB, patch)
2016-11-14 14:24 PST
,
Myles C. Maxfield
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(16)
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2016-11-08 14:31:52 PST
Created
attachment 294185
[details]
WIP
Myles C. Maxfield
Comment 2
2016-11-08 19:16:31 PST
Created
attachment 294209
[details]
WIP
Myles C. Maxfield
Comment 3
2016-11-09 00:31:40 PST
Created
attachment 294224
[details]
WIP
Myles C. Maxfield
Comment 4
2016-11-09 13:24:24 PST
Created
attachment 294275
[details]
WIP
WebKit Commit Bot
Comment 5
2016-11-09 13:26:40 PST
Attachment 294275
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3242: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3615: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3615: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3617: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3618: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3619: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3620: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3621: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3622: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3623: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3624: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3625: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3626: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3627: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3628: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3629: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3630: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3631: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3632: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3633: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3634: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3635: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3636: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3637: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3638: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3639: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3640: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3641: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3642: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3643: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3644: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3645: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3646: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3647: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3648: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3649: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3650: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3651: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3652: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3653: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3654: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3655: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3656: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3657: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3658: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3659: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3660: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3661: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3662: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3663: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3664: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3665: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3666: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3667: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3668: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3669: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3670: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3671: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3672: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3673: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3674: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3675: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 63 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 6
2016-11-09 13:44:17 PST
Created
attachment 294280
[details]
WIP
WebKit Commit Bot
Comment 7
2016-11-09 13:47:12 PST
Attachment 294280
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3242: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3615: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3615: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3617: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3618: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3619: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3620: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3621: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3622: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3623: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3624: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3625: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3626: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3627: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3628: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3629: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3630: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3631: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3632: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3633: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3634: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3635: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3636: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3637: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3638: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3639: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3640: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3641: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3642: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3643: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3644: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3645: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3646: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3647: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3648: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3649: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3650: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3651: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3652: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3653: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3654: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3655: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3656: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3657: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3658: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3659: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3660: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3661: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3662: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3663: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3664: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3665: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3666: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3667: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3668: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3669: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3670: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3671: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3672: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3673: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3674: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3675: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 63 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 8
2016-11-09 14:45:34 PST
Comment on
attachment 294280
[details]
WIP
Attachment 294280
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/2485427
New failing tests: webgl/1.0.2/conformance/textures/tex-sub-image-2d-bad-args.html http/tests/webgl/1.0.2/texSubImage2DHTML.html webgl/1.0.3/conformance/extensions/ext-sRGB.html webgl/1.0.2/conformance/more/functions/texSubImage2DHTMLBadArgs.html webgl/1.0.2/conformance/more/functions/texSubImage2DBadArgs.html
Build Bot
Comment 9
2016-11-09 14:45:39 PST
Created
attachment 294293
[details]
Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 10
2016-11-09 14:51:59 PST
Comment on
attachment 294280
[details]
WIP
Attachment 294280
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/2485444
New failing tests: webgl/1.0.2/conformance/textures/tex-sub-image-2d-bad-args.html http/tests/webgl/1.0.2/texSubImage2DHTML.html webgl/1.0.3/conformance/extensions/ext-sRGB.html webgl/1.0.2/conformance/more/functions/texSubImage2DHTMLBadArgs.html webgl/1.0.2/conformance/more/functions/texSubImage2DBadArgs.html
Build Bot
Comment 11
2016-11-09 14:52:04 PST
Created
attachment 294294
[details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 12
2016-11-09 16:52:33 PST
Comment on
attachment 294280
[details]
WIP
Attachment 294280
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/2486004
New failing tests: webgl/1.0.2/conformance/textures/tex-sub-image-2d-bad-args.html http/tests/webgl/1.0.2/texSubImage2DHTML.html webgl/1.0.2/conformance/more/functions/texSubImage2DBadArgs.html webgl/1.0.2/conformance/more/functions/texSubImage2DHTMLBadArgs.html webgl/1.0.3/conformance/extensions/ext-sRGB.html
Build Bot
Comment 13
2016-11-09 16:52:38 PST
Created
attachment 294306
[details]
Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Myles C. Maxfield
Comment 14
2016-11-09 18:09:20 PST
Created
attachment 294317
[details]
WIP
Myles C. Maxfield
Comment 15
2016-11-10 01:23:00 PST
Created
attachment 294346
[details]
WIP
Myles C. Maxfield
Comment 16
2016-11-10 11:48:01 PST
Created
attachment 294392
[details]
WIP
Myles C. Maxfield
Comment 17
2016-11-10 11:59:25 PST
Created
attachment 294395
[details]
WIP
Myles C. Maxfield
Comment 18
2016-11-10 13:46:34 PST
Created
attachment 294408
[details]
WIP
Myles C. Maxfield
Comment 19
2016-11-10 14:43:02 PST
Created
attachment 294418
[details]
WIP
Myles C. Maxfield
Comment 20
2016-11-10 15:45:06 PST
Created
attachment 294426
[details]
WIP
WebKit Commit Bot
Comment 21
2016-11-10 15:48:33 PST
Attachment 294426
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3954: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3954: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3956: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3957: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3958: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3959: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3960: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3961: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3962: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3963: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3964: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3965: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3966: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3967: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3968: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3969: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3970: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3971: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3972: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3973: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3974: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3975: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3976: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3977: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3978: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3979: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3980: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3981: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3982: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3983: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3984: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3985: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3986: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3987: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3988: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3989: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3990: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3991: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3992: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3993: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3994: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3995: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3996: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3997: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3998: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3999: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4000: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4001: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4002: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4003: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4004: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4005: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4006: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4007: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4008: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4009: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4010: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4011: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4012: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4013: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4014: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 62 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 22
2016-11-11 15:29:38 PST
Created
attachment 294551
[details]
WIP
Myles C. Maxfield
Comment 23
2016-11-11 16:16:47 PST
Created
attachment 294561
[details]
Patch
WebKit Commit Bot
Comment 24
2016-11-11 16:17:47 PST
Attachment 294561
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3939: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3939: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3941: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3942: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3943: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3944: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3945: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3946: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3947: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3948: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3949: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3950: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3951: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3952: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3953: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3954: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3955: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3956: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3957: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3958: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3959: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3960: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3961: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3962: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3963: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3964: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3965: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3966: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3967: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3968: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3969: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3970: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3971: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3972: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3973: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3974: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3975: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3976: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3977: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3978: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3979: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3980: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3981: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3982: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3983: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3984: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3985: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3986: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3987: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3988: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3989: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3990: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3991: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3992: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3993: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3994: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3995: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3996: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3997: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3998: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3999: Extra space before ) [whitespace/parens] [2] Total errors found: 61 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 25
2016-11-11 16:21:16 PST
Comment on
attachment 294561
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=294561&action=review
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2877 > + case GraphicsContext3D::R11F_G11F_B10F: // litherum
Whoops!
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2906 > + case GraphicsContext3D::RGB10_A2UI: // litherum
Whoops!
Myles C. Maxfield
Comment 26
2016-11-11 16:34:38 PST
Created
attachment 294565
[details]
Patch
WebKit Commit Bot
Comment 27
2016-11-11 16:36:53 PST
Attachment 294565
[details]
did not pass style-queue: ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3141: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3961: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3961: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3963: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3964: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3965: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3966: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3967: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3968: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3969: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3970: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3971: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3972: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3973: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3974: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3975: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3976: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3977: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3978: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3979: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3980: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3981: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3982: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3983: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3984: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3985: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3986: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3987: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3988: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3989: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3990: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3991: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3992: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3993: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3994: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3995: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3996: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3997: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3998: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3999: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4000: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4001: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4002: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4003: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4004: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4005: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4006: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4007: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4008: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4009: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4010: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4011: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4012: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4013: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4014: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4015: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4016: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4017: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4018: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4019: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4020: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4021: Extra space before ) [whitespace/parens] [2] Total errors found: 62 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 28
2016-11-14 11:12:44 PST
Comment on
attachment 294561
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=294561&action=review
> Source/WebCore/ChangeLog:96 > + (WebCore::GraphicsContext3D::packPixels): It is possible to try to > + copy data from a video into one of these new formats. Currently, we > + implement this by swizzling on the CPU. Rather than implementing all the > + swizzling functions in this patch (which would make this patch much > + larger), simply bail in this case. We will implement this later.
Please add a FIXME.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:-1314 > - if (GraphicsContext3D::getClearBitsByFormat(format) & (GraphicsContext3D::DEPTH_BUFFER_BIT | GraphicsContext3D::STENCIL_BUFFER_BIT)) {
I don't see this test anywhere now. Is that ok?
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3015 > + // FIXME: Only handle some enum values in WebGL 1.
I think you do this below.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3079 > + if (type != GraphicsContext3D::UNSIGNED_BYTE || pixels.getType() != JSC::TypeUint8) { > + synthesizeGLError(GraphicsContext3D::INVALID_ENUM, "readPixels", "type does not match internal format"); > + return; > + } > + if (format != GraphicsContext3D::RED && format != GraphicsContext3D::RG && format != GraphicsContext3D::RGB && format != GraphicsContext3D::RGBA) { > + synthesizeGLError(GraphicsContext3D::INVALID_ENUM, "readPixels", "Unknown format"); > + return;
Since these are very similar in every theme, can you think of a way to simplify the code? maybe use a macro?
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3084 > + if (numberOfComponentsForFormat(format) < internalFormatComponentCount) { > + synthesizeGLError(GraphicsContext3D::INVALID_ENUM, "readPixels", "Not enough components in format"); > + return; > + }
Maybe this could be done for every format theme, before the switch?
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:-2904 > -#if OS(DARWIN) > - if (m_isRobustnessEXTSupported) // we haven't computed padding > - m_context->computeImageSizeInBytes(format, type, width, height, m_packAlignment, &totalBytesRequired, &padding); > - // FIXME: remove this section when GL driver bug on Mac AND the GLES driver bug > - // on QC is fixed, i.e., when alpha is off, readPixels should > - // set alpha to 255 instead of 0. > - if (!m_framebufferBinding && !m_context->getContextAttributes().alpha) { > - unsigned char* pixels = reinterpret_cast<unsigned char*>(data); > - for (GC3Dsizei iy = 0; iy < height; ++iy) { > - for (GC3Dsizei ix = 0; ix < width; ++ix) { > - pixels[3] = 255; > - pixels += 4; > - } > - pixels += padding; > - } > - } > -#endif
I didn't even know this was here. Why do you think we don' need this any more?
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3500 > + if (m_unpackAlignment != 1) > + m_context->pixelStorei(GraphicsContext3D::UNPACK_ALIGNMENT, 1); > + > + texSubImage2DBase(target, level, xoffset, yoffset, image->width(), image->height(), format, format, type, needConversion ? data.data() : imagePixelData); > + if (m_unpackAlignment != 1) > + m_context->pixelStorei(GraphicsContext3D::UNPACK_ALIGNMENT, m_unpackAlignment);
Can you explain why you set it to 1? Also, add a blank line after texSubImage2DBase.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3537 > + texSubImage2DBase(target, level, xoffset, yoffset, width, height, internalFormat, format, type, data); > if (changeUnpackAlignment)
Add another blank line here.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3581 > + texSubImage2DBase(target, level, xoffset, yoffset, pixels->width(), pixels->height(), format, format, type, needConversion ? data.data() : pixels->data()->data()); > + if (m_unpackAlignment != 1)
Ditto.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3664 > + return WTF::visit(visitor, source.value());
Why do you think this visitor approach is better/cleaner than just a conditional?
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3674 > + if (arrayType && arrayType.value() != JSC::TypeUint8) { > + synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, functionName, "type UNSIGNED_BYTE but ArrayBufferView not Uint8Array"); > + return false; > + }
Here's another case I wish we could do without so much duplication.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3765 > + if (pixels->byteLength() < totalBytesRequired) { > + if (m_unpackAlignment != 1) { > + m_context->computeImageSizeInBytes(format, type, width, height, 1, &totalBytesRequired, 0); > + if (pixels->byteLength() == totalBytesRequired) { > + synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, functionName, "ArrayBufferView not big enough for request with UNPACK_ALIGNMENT > 1"); > + return false; > + } > + }
I think you should lift the inner conditional out to before this. Is my logic right? I hope so.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3847 > + if (m_webglDepthTexture || !isWebGL1()) { > + if (level > 0) { > + synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, functionName, "level must be 0 for depth formats"); > + return false; > + } > + break; > + } > + synthesizeGLError(GraphicsContext3D::INVALID_ENUM, functionName, "depth texture formats not enabled"); > + return false;
I like it better as: if (!m_webglDepthTexture && isWebGL1()) { error; return false; } if (level > 0) { error; return false; } break;
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3853 > + if (m_extsRGB) > + break; > + synthesizeGLError(GraphicsContext3D::INVALID_ENUM, functionName, "sRGB texture formats not enabled"); > + return false;
I like it better as: if (!m_extsRGB) { synth.. return false; } break; The same goes for other tests down below. I think it reads better to keep the break statement at the end, if the logic doesn't get too unclear. Also means that you're consistently checking for the error conditions.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4041 > + ASSERT((xoffset + width) >= 0); > + ASSERT((yoffset + height) >= 0);
These asserts won't help if there is overflow, but I guess that's ok.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4083 > + if (clip2D(x, y, width, height, getBoundFramebufferWidth(), getBoundFramebufferHeight(), &clippedX, &clippedY, &clippedWidth, &clippedHeight)) { > + m_context->texImage2DResourceSafe(target, level, internalFormat, width, height, border, > + internalFormat, GraphicsContext3D::UNSIGNED_BYTE, m_unpackAlignment); > + if (clippedWidth > 0 && clippedHeight > 0) { > + m_context->copyTexSubImage2D(target, level, clippedX - x, clippedY - y, > + clippedX, clippedY, clippedWidth, clippedHeight);
Do we ever check that x and y are positive?
> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:251 > + case GraphicsContext3D::RGB: > + format = GraphicsContext3D::RGB; > + type = GraphicsContext3D::UNSIGNED_BYTE;
Might as well MACRO all this?
Myles C. Maxfield
Comment 29
2016-11-14 14:23:20 PST
Comment on
attachment 294561
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=294561&action=review
>> Source/WebCore/ChangeLog:96 >> + larger), simply bail in this case. We will implement this later. > > Please add a FIXME.
I already did. Look at line 651.
>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:-1314 >> - if (GraphicsContext3D::getClearBitsByFormat(format) & (GraphicsContext3D::DEPTH_BUFFER_BIT | GraphicsContext3D::STENCIL_BUFFER_BIT)) { > > I don't see this test anywhere now. Is that ok?
Looking at getClearBitsByFormat() shows that this function is checking to see if the format is a depth format or a stencil format. That's what the new implementation of this function does (just more explicitly).
>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3084 >> + } > > Maybe this could be done for every format theme, before the switch?
Nope, because it shouldn't be done for the packed formats. I've put it into a macro so the code isn't duplicated.
>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3500 >> + m_context->pixelStorei(GraphicsContext3D::UNPACK_ALIGNMENT, m_unpackAlignment); > > Can you explain why you set it to 1? Also, add a blank line after texSubImage2DBase.
This is preexisting code.
>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3664 >> + return WTF::visit(visitor, source.value()); > > Why do you think this visitor approach is better/cleaner than just a conditional?
It's required with the Variant class. Also type safety.
>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4083 >> + clippedX, clippedY, clippedWidth, clippedHeight); > > Do we ever check that x and y are positive?
The spec states "copyTexImage2D is defined to generate the RGBA value (0, 0, 0, 0) for any pixel outside of the bound framebuffer." Sounds like negative values are allowed.
Myles C. Maxfield
Comment 30
2016-11-14 14:24:15 PST
Created
attachment 294747
[details]
Patch for committing
WebKit Commit Bot
Comment 31
2016-11-14 14:27:57 PST
Attachment 294747
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:254: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:254: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:255: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:256: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:257: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:258: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:259: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:260: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:261: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:262: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:263: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:264: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:265: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:266: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:267: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:268: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:269: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:270: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:271: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:272: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:273: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:274: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:275: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:276: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:277: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:278: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:279: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:280: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:281: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:282: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:283: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:284: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:285: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:286: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:287: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:288: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:289: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:290: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:291: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:292: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:293: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:294: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:295: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:296: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:297: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:298: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:299: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:300: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:301: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:302: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:303: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:304: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:305: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:306: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:307: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:308: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:309: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:310: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:311: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:312: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:313: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:315: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:316: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3111: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3111: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3111: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3112: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3114: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3115: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3118: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3118: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3119: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3120: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3121: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3122: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3124: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3852: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3852: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3854: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3855: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3856: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3857: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3858: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3859: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3860: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3861: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3862: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3863: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3864: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3865: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3866: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3867: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3868: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3869: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3870: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3871: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3872: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3873: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3874: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3875: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3876: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3877: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3878: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3879: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3880: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3881: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3882: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3883: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3884: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3885: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3886: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3887: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3888: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3889: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3890: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3891: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3892: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3893: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3894: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3895: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3896: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3897: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3898: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3899: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3900: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3901: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3902: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3903: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3904: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3905: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3906: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3907: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3908: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3909: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3910: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3911: Extra space before ) [whitespace/parens] [2] ERROR: Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3912: Extra space before ) [whitespace/parens] [2] Total errors found: 139 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 32
2016-11-14 15:47:27 PST
Comment on
attachment 294747
[details]
Patch for committing Rejecting
attachment 294747
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 294747, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output:
http://webkit-queues.webkit.org/results/2516360
Myles C. Maxfield
Comment 33
2016-11-14 18:42:44 PST
Committed
r208724
: <
http://trac.webkit.org/changeset/208724
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug