RESOLVED FIXED 164515
Move Node from ExceptionCode to ExceptionOr 
https://bugs.webkit.org/show_bug.cgi?id=164515
Summary Move Node from ExceptionCode to ExceptionOr
Darin Adler
Reported 2016-11-08 08:54:14 PST
Node.idl is the last IDL file using "LegacyException" and this patch will finish that file off.
Attachments
Patch (258.52 KB, patch)
2016-11-09 20:05 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (291.73 KB, application/zip)
2016-11-09 21:07 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (249.79 KB, application/zip)
2016-11-09 21:13 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews114 for mac-yosemite (1.54 MB, application/zip)
2016-11-09 22:10 PST, Build Bot 		no flags
Details
Patch (265.48 KB, patch)
2016-11-10 08:59 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (267.95 KB, patch)
2016-11-10 20:30 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (276.06 KB, patch)
2016-11-10 21:15 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-11-08 08:55:05 PST
Since the patch conflicts with the Range one, I won’t upload a patch for EWS or review until the Range patch is committed and I can rebase.
Darin Adler
Comment 2 2016-11-08 08:55:31 PST
But I have this work done and compiling locally.
Darin Adler
Comment 3 2016-11-09 20:05:10 PST
Created attachment 294326 [details] Patch
Build Bot
Comment 4 2016-11-09 21:07:16 PST
Comment on attachment 294326 [details] Patch Attachment 294326 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2487041 Number of test failures exceeded the failure limit.
Build Bot
Comment 5 2016-11-09 21:07:20 PST
Created attachment 294332 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-11-09 21:13:43 PST
Comment on attachment 294326 [details] Patch Attachment 294326 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2487043 Number of test failures exceeded the failure limit.
Build Bot
Comment 7 2016-11-09 21:13:47 PST
Created attachment 294333 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 8 2016-11-09 22:10:18 PST
Comment on attachment 294326 [details] Patch Attachment 294326 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2487302 Number of test failures exceeded the failure limit.
Build Bot
Comment 9 2016-11-09 22:10:21 PST
Created attachment 294337 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Darin Adler
Comment 10 2016-11-10 08:59:05 PST
Created attachment 294376 [details] Patch
Darin Adler
Comment 11 2016-11-10 20:30:12 PST
Created attachment 294466 [details] Patch
Darin Adler
Comment 12 2016-11-10 21:15:32 PST
Created attachment 294470 [details] Patch
Darin Adler
Comment 13 2016-11-10 21:55:16 PST
OK, EWS seems to be passing on this patch now, so ready for review.
Sam Weinig
Comment 14 2016-11-11 11:53:16 PST
Comment on attachment 294470 [details] Patch Awesome!
WebKit Commit Bot
Comment 15 2016-11-11 12:19:14 PST
Comment on attachment 294470 [details] Patch Clearing flags on attachment: 294470 Committed r208603: <http://trac.webkit.org/changeset/208603>
WebKit Commit Bot
Comment 16 2016-11-11 12:19:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.