Bug 164513 - [Modern Media Controls] UI Library: iOS inline controls
Summary: [Modern Media Controls] UI Library: iOS inline controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari 10
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-08 08:24 PST by Antoine Quint
Modified: 2016-11-09 11:34 PST (History)
2 users (show)

See Also:

Attachments
Patch (54.76 KB, patch)
2016-11-08 08:25 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (54.76 KB, patch)
2016-11-08 08:26 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (56.88 KB, patch)
2016-11-08 09:49 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (56.61 KB, patch)
2016-11-08 11:58 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-11-08 08:24:04 PST 
This covers the JS class to instantiate the media controls for inline media playback on iOS.
Comment 1 Antoine Quint 2016-11-08 08:24:16 PST 
<rdar://problem/27989475>
Comment 2 Antoine Quint 2016-11-08 08:25:46 PST 
Created attachment 294160 [details]
Patch
Comment 3 Antoine Quint 2016-11-08 08:26:28 PST 
Created attachment 294161 [details]
Patch
Comment 4 Antoine Quint 2016-11-08 09:49:47 PST 
Created attachment 294166 [details]
Patch
Comment 5 Dean Jackson 2016-11-08 10:28:11 PST 
Comment on attachment 294166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294166&action=review

> Source/WebCore/ChangeLog:10
> +        We introduce a new IOSFullscreenMediaControls class which can be used to instantiate media controls
> +        for inline playback on iOS.

I think you meant IOSInlineMediaControls

> Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css:34
> +    background-color: rgba(73, 73, 73, 0.45);
> +    -webkit-backdrop-filter: saturate(180%) blur(20px);

You can use the system style on iOS.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:11183
> -		9908B0F11BCACF9100ED3F64 /* ReadableByteStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableByteStreamInternals.js; sourceTree = "<group>"; };
>  		9908B0F11BCACF9100ED0F75 /* WritableStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = WritableStreamInternals.js; sourceTree = "<group>"; };
> +		9908B0F11BCACF9100ED3F64 /* ReadableByteStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableByteStreamInternals.js; sourceTree = "<group>"; };
>  		9908B0F21BCACF9100ED0F65 /* ReadableStreamDefaultReader.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableStreamDefaultReader.js; sourceTree = "<group>"; };

what is all this?
Comment 6 Antoine Quint 2016-11-08 11:55:11 PST 
(In reply to comment #5)
> Comment on attachment 294166 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=294166&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        We introduce a new IOSFullscreenMediaControls class which can be used to instantiate media controls
> > +        for inline playback on iOS.
> 
> I think you meant IOSInlineMediaControls

Duh.

> > Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css:34
> > +    background-color: rgba(73, 73, 73, 0.45);
> > +    -webkit-backdrop-filter: saturate(180%) blur(20px);
> 
> You can use the system style on iOS.

Correct! I'll change this when landing.

> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:11183
> > -		9908B0F11BCACF9100ED3F64 /* ReadableByteStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableByteStreamInternals.js; sourceTree = "<group>"; };
> >  		9908B0F11BCACF9100ED0F75 /* WritableStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = WritableStreamInternals.js; sourceTree = "<group>"; };
> > +		9908B0F11BCACF9100ED3F64 /* ReadableByteStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableByteStreamInternals.js; sourceTree = "<group>"; };
> >  		9908B0F21BCACF9100ED0F65 /* ReadableStreamDefaultReader.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableStreamDefaultReader.js; sourceTree = "<group>"; };
> 
> what is all this?

The doing of Xcode when adding a new file.
Comment 7 Antoine Quint 2016-11-08 11:58:18 PST 
Created attachment 294176 [details]
Patch
Comment 8 Antoine Quint 2016-11-09 11:34:46 PST 
https://trac.webkit.org/changeset/208454