Bug 164513 – [Modern Media Controls] UI Library: iOS inline controls

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

This covers the JS class to instantiate the media controls for inline media playback on iOS.

[Antoine Quint]

<rdar://problem/27989475>

[Antoine Quint]

Created attachment 294160 [details]
Patch

[Antoine Quint]

Created attachment 294161 [details]
Patch

[Antoine Quint]

Created attachment 294166 [details]
Patch

[Dean Jackson]

Comment on attachment 294166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294166&action=review

> Source/WebCore/ChangeLog:10
> +        We introduce a new IOSFullscreenMediaControls class which can be used to instantiate media controls
> +        for inline playback on iOS.

I think you meant IOSInlineMediaControls

> Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css:34
> +    background-color: rgba(73, 73, 73, 0.45);
> +    -webkit-backdrop-filter: saturate(180%) blur(20px);

You can use the system style on iOS.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:11183
> -		9908B0F11BCACF9100ED3F64 /* ReadableByteStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableByteStreamInternals.js; sourceTree = "<group>"; };
>  		9908B0F11BCACF9100ED0F75 /* WritableStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = WritableStreamInternals.js; sourceTree = "<group>"; };
> +		9908B0F11BCACF9100ED3F64 /* ReadableByteStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableByteStreamInternals.js; sourceTree = "<group>"; };
>  		9908B0F21BCACF9100ED0F65 /* ReadableStreamDefaultReader.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableStreamDefaultReader.js; sourceTree = "<group>"; };

what is all this?

[Antoine Quint]

(In reply to comment #5)
> Comment on attachment 294166 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=294166&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        We introduce a new IOSFullscreenMediaControls class which can be used to instantiate media controls
> > +        for inline playback on iOS.
> 
> I think you meant IOSInlineMediaControls

Duh.

> > Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css:34
> > +    background-color: rgba(73, 73, 73, 0.45);
> > +    -webkit-backdrop-filter: saturate(180%) blur(20px);
> 
> You can use the system style on iOS.

Correct! I'll change this when landing.

> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:11183
> > -		9908B0F11BCACF9100ED3F64 /* ReadableByteStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableByteStreamInternals.js; sourceTree = "<group>"; };
> >  		9908B0F11BCACF9100ED0F75 /* WritableStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = WritableStreamInternals.js; sourceTree = "<group>"; };
> > +		9908B0F11BCACF9100ED3F64 /* ReadableByteStreamInternals.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableByteStreamInternals.js; sourceTree = "<group>"; };
> >  		9908B0F21BCACF9100ED0F65 /* ReadableStreamDefaultReader.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = ReadableStreamDefaultReader.js; sourceTree = "<group>"; };
> 
> what is all this?

The doing of Xcode when adding a new file.

[Antoine Quint]

Created attachment 294176 [details]
Patch

[Antoine Quint]

https://trac.webkit.org/changeset/208454