Implement visual-viewport based position:fixed handling for Mac async scrolling

[Simon Fraser (smfr)]

Implement visual-viewport based position:fixed handling for Mac async scrolling

[Simon Fraser (smfr)]

Created attachment 294101 [details]
Patch

[Tim Horton]

Comment on attachment 294101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294101&action=review

> Source/WebCore/page/FrameView.cpp:1880
> +    visibleContentRect.scale(1 / frameScaleFactor()); // Note thate frameScaleFactor() returns 1 for delegated scrolling (e.g. iOS WK2)

thate!

> Source/WebCore/page/FrameView.h:256
> +        Yes,

Yes is 0 and No is 1?

> Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.cpp:107
> +    visibleContentSize.scale(1 / scale); // GROSS.

So is the comment.

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:112
> +    // FIXME: do we need to calculate a layoutViewport?

Do we?

[Build Bot]

Comment on attachment 294101 [details]
Patch

Attachment 294101 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2470478

New failing tests:
tiled-drawing/scrolling/fixed/remove-scrolling-role.html

[Build Bot]

Created attachment 294108 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Simon Fraser (smfr)]

Created attachment 294297 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/208503