Bug 164492 - [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
Summary: [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-07 16:08 PST by Andy Estes
Modified: 2016-12-02 17:32 PST (History)
10 users (show)

See Also:


Attachments
Patch (36.50 KB, patch)
2016-11-29 12:29 PST, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (36.93 KB, patch)
2016-11-30 16:44 PST, Andy Estes
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (45.19 KB, application/zip)
2016-11-30 17:32 PST, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (50.33 KB, application/zip)
2016-11-30 17:46 PST, Build Bot
no flags Details
Patch (36.74 KB, patch)
2016-12-02 16:55 PST, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-11-07 16:08:48 PST
[Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
Comment 1 Andy Estes 2016-11-29 12:29:18 PST
Created attachment 295620 [details]
Patch
Comment 2 mitz 2016-11-29 17:38:03 PST
Who or what ensures the rfc1034-conformance of the bundle identifiers in this setup? Is it just relying on the current product names being conforming?
Comment 3 Andy Estes 2016-11-29 18:18:43 PST
(In reply to comment #2)
> Who or what ensures the rfc1034-conformance of the bundle identifiers in
> this setup? Is it just relying on the current product names being conforming?

Yeah, I'm relying on the current product names conforming. I removed :rfc1034identifier from the handful of places that used it for consistency, but maybe I should've added it to the places that omitted it instead. That does sound safer (I don't think any of our current names would change either way).
Comment 4 Andy Estes 2016-11-30 16:44:44 PST
Created attachment 295788 [details]
Patch
Comment 5 mitz 2016-11-30 16:47:57 PST
Comment on attachment 295788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295788&action=review

> Tools/TestWebKitAPI/Configurations/InjectedBundle.xcconfig:26
> +PRODUCT_BUNDLE_IDENTIFIER = com.yourcompany.$(PRODUCT_NAME:rfc1034identifier);

:|
Comment 6 Build Bot 2016-11-30 17:32:28 PST
Comment on attachment 295788 [details]
Patch

Attachment 295788 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2598169

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-11-30 17:32:31 PST
Created attachment 295795 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-11-30 17:46:30 PST
Comment on attachment 295788 [details]
Patch

Attachment 295788 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2598182

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-11-30 17:46:33 PST
Created attachment 295802 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Andy Estes 2016-12-02 16:55:12 PST
Created attachment 296023 [details]
Patch
Comment 11 Andy Estes 2016-12-02 17:02:29 PST
(In reply to comment #5)
> Comment on attachment 295788 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295788&action=review
> 
> > Tools/TestWebKitAPI/Configurations/InjectedBundle.xcconfig:26
> > +PRODUCT_BUNDLE_IDENTIFIER = com.yourcompany.$(PRODUCT_NAME:rfc1034identifier);
> 
> :|

Changed to com.apple.$(PRODUCT_NAME:rfc1034identifier).

The test failures from the patch you r+'d were due to using :rfc1034identifier on PRODUCT_NAMEs that were already in reverse-DNS format, e.g. WebKit'2 DatabaseService:

    PRODUCT_NAME = com.apple.WebKit.Databases;

Setting PRODUCT_BUNDLE_IDENTIFIER to $(PRODUCT_NAME:rfc1034identifier) would replace the dots with hyphens, so I reverted to using $(PRODUCT_NAME) in those cases.
Comment 12 WebKit Commit Bot 2016-12-02 17:32:12 PST
Comment on attachment 296023 [details]
Patch

Clearing flags on attachment: 296023

Committed r209288: <http://trac.webkit.org/changeset/209288>
Comment 13 WebKit Commit Bot 2016-12-02 17:32:17 PST
All reviewed patches have been landed.  Closing bug.