[Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
Created attachment 295620 [details] Patch
Who or what ensures the rfc1034-conformance of the bundle identifiers in this setup? Is it just relying on the current product names being conforming?
(In reply to comment #2) > Who or what ensures the rfc1034-conformance of the bundle identifiers in > this setup? Is it just relying on the current product names being conforming? Yeah, I'm relying on the current product names conforming. I removed :rfc1034identifier from the handful of places that used it for consistency, but maybe I should've added it to the places that omitted it instead. That does sound safer (I don't think any of our current names would change either way).
Created attachment 295788 [details] Patch
Comment on attachment 295788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295788&action=review > Tools/TestWebKitAPI/Configurations/InjectedBundle.xcconfig:26 > +PRODUCT_BUNDLE_IDENTIFIER = com.yourcompany.$(PRODUCT_NAME:rfc1034identifier); :|
Comment on attachment 295788 [details] Patch Attachment 295788 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2598169 Number of test failures exceeded the failure limit.
Created attachment 295795 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 295788 [details] Patch Attachment 295788 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2598182 Number of test failures exceeded the failure limit.
Created attachment 295802 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 296023 [details] Patch
(In reply to comment #5) > Comment on attachment 295788 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295788&action=review > > > Tools/TestWebKitAPI/Configurations/InjectedBundle.xcconfig:26 > > +PRODUCT_BUNDLE_IDENTIFIER = com.yourcompany.$(PRODUCT_NAME:rfc1034identifier); > > :| Changed to com.apple.$(PRODUCT_NAME:rfc1034identifier). The test failures from the patch you r+'d were due to using :rfc1034identifier on PRODUCT_NAMEs that were already in reverse-DNS format, e.g. WebKit'2 DatabaseService: PRODUCT_NAME = com.apple.WebKit.Databases; Setting PRODUCT_BUNDLE_IDENTIFIER to $(PRODUCT_NAME:rfc1034identifier) would replace the dots with hyphens, so I reverted to using $(PRODUCT_NAME) in those cases.
Comment on attachment 296023 [details] Patch Clearing flags on attachment: 296023 Committed r209288: <http://trac.webkit.org/changeset/209288>
All reviewed patches have been landed. Closing bug.