NEW 164486
Refactor ViewGestureController to begin supporting multiple simultaneous swipes 
https://bugs.webkit.org/show_bug.cgi?id=164486
Summary Refactor ViewGestureController to begin supporting multiple simultaneous swipes
Tim Horton
Reported 2016-11-07 11:08:47 PST
Refactor ViewGestureController to begin supporting multiple simultaneous swipes
Attachments
WIP, incomplete (60.92 KB, patch)
2016-11-07 11:09 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-11-07 11:09:18 PST
Created attachment 294071 [details] WIP, incomplete
WebKit Commit Bot
Comment 2 2016-12-10 00:39:15 PST
Attachment 294071 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:251: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:251: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:108: The parameter name "transition" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:108: The parameter name "direction" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:229: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 5 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Note You need to log in before you can comment on or make changes to this bug.