Bug 164484 - preprocessor.pm: Use shellwords() instead of splitting preprocessor command by space
Summary: preprocessor.pm: Use shellwords() instead of splitting preprocessor command b...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-07 09:46 PST by Konstantin Tokarev
Modified: 2016-11-08 02:43 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2016-11-07 09:49 PST, Konstantin Tokarev
no flags Details | Formatted Diff | Diff
Patch (2.22 KB, patch)
2016-11-07 10:41 PST, Konstantin Tokarev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-11-07 09:46:48 PST
Now any quoted or escaped command line arguments can be passed in --preprocessor value independently of OS.
Comment 1 Konstantin Tokarev 2016-11-07 09:48:37 PST
In particular, this is needed to compile with MinGW, because preprocessor.pm does not apply split() on Windows.
Comment 2 Konstantin Tokarev 2016-11-07 09:49:52 PST
Created attachment 294066 [details]
Patch
Comment 3 Konstantin Tokarev 2016-11-07 10:41:08 PST
Created attachment 294069 [details]
Patch
Comment 4 Konstantin Tokarev 2016-11-07 11:57:16 PST
MinGW works fine after r207412 without this patch, and it doesn't build in EWS
Comment 5 Konstantin Tokarev 2016-11-08 02:43:33 PST
It would be great if we used shellwords everywhere instead of splitting by space for parsing command line tokens, but not this time.