Bug 164482 - [MediaStream][Mac] Mark captured video frames as ready for display immediately
Summary: [MediaStream][Mac] Mark captured video frames as ready for display immediately
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-07 08:03 PST by Eric Carlson
Modified: 2017-01-12 09:24 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch. (11.68 KB, patch)
2016-11-07 08:29 PST, Eric Carlson 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (11.35 KB, patch)
2016-11-08 06:17 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-11-07 08:03:32 PST 
Flag frames captured from a video device to be displayed immediately.  Also enqueue frames when the sample buffer display layer isn't ready for new frames instead of discarding them.
Comment 1 Radar WebKit Bug Importer 2016-11-07 08:06:22 PST 
<rdar://problem/29139073>
Comment 2 Eric Carlson 2016-11-07 08:29:33 PST 
Created attachment 294064 [details]
Proposed patch.
Comment 3 WebKit Commit Bot 2016-11-07 08:32:16 PST 
Attachment 294064 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:133:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Jer Noble 2016-11-07 09:28:00 PST 
Comment on attachment 294064 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=294064&action=review

> Source/WebCore/platform/cf/CoreMediaSoftLink.cpp:107
> +SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreMedia, kCMSampleAttachmentKey_IsDependedOnByOthers, CFStringRef)

Unnecessary?

> Source/WebCore/platform/cf/CoreMediaSoftLink.h:170
> +SOFT_LINK_CONSTANT_FOR_HEADER(WebCore, CoreMedia, kCMSampleAttachmentKey_IsDependedOnByOthers, CFStringRef)
> +#define kCMSampleAttachmentKey_IsDependedOnByOthers get_CoreMedia_kCMSampleAttachmentKey_IsDependedOnByOthers()

Ditto.
Comment 5 Eric Carlson 2016-11-08 06:15:27 PST 
(In reply to comment #4)
> Comment on attachment 294064 [details]
> Proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=294064&action=review
> 
> > Source/WebCore/platform/cf/CoreMediaSoftLink.cpp:107
> > +SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreMedia, kCMSampleAttachmentKey_IsDependedOnByOthers, CFStringRef)
> 
> Unnecessary?
> 
> > Source/WebCore/platform/cf/CoreMediaSoftLink.h:170
> > +SOFT_LINK_CONSTANT_FOR_HEADER(WebCore, CoreMedia, kCMSampleAttachmentKey_IsDependedOnByOthers, CFStringRef)
> > +#define kCMSampleAttachmentKey_IsDependedOnByOthers get_CoreMedia_kCMSampleAttachmentKey_IsDependedOnByOthers()
> 
> Ditto.

Both removed. 

Thanks for the review!
Comment 6 Eric Carlson 2016-11-08 06:17:51 PST 
Created attachment 294156 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2016-11-09 10:30:41 PST 
Comment on attachment 294156 [details]
Patch for landing.

Clearing flags on attachment: 294156

Committed r208444: <http://trac.webkit.org/changeset/208444>