RESOLVED FIXED 164482
[MediaStream][Mac] Mark captured video frames as ready for display immediately 
https://bugs.webkit.org/show_bug.cgi?id=164482
Summary [MediaStream][Mac] Mark captured video frames as ready for display immediately
Eric Carlson
Reported 2016-11-07 08:03:32 PST
Flag frames captured from a video device to be displayed immediately. Also enqueue frames when the sample buffer display layer isn't ready for new frames instead of discarding them.
Attachments
Proposed patch. (11.68 KB, patch)
2016-11-07 08:29 PST, Eric Carlson 		jer.noble: review+
DetailsFormatted DiffDiff
Patch for landing. (11.35 KB, patch)
2016-11-08 06:17 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-11-07 08:06:22 PST
<rdar://problem/29139073>
Eric Carlson
Comment 2 2016-11-07 08:29:33 PST
Created attachment 294064 [details] Proposed patch.
WebKit Commit Bot
Comment 3 2016-11-07 08:32:16 PST
Attachment 294064 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:133: No space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 4 2016-11-07 09:28:00 PST
Comment on attachment 294064 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=294064&action=review > Source/WebCore/platform/cf/CoreMediaSoftLink.cpp:107 > +SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreMedia, kCMSampleAttachmentKey_IsDependedOnByOthers, CFStringRef) Unnecessary? > Source/WebCore/platform/cf/CoreMediaSoftLink.h:170 > +SOFT_LINK_CONSTANT_FOR_HEADER(WebCore, CoreMedia, kCMSampleAttachmentKey_IsDependedOnByOthers, CFStringRef) > +#define kCMSampleAttachmentKey_IsDependedOnByOthers get_CoreMedia_kCMSampleAttachmentKey_IsDependedOnByOthers() Ditto.
Eric Carlson
Comment 5 2016-11-08 06:15:27 PST
(In reply to comment #4) > Comment on attachment 294064 [details] > Proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=294064&action=review > > > Source/WebCore/platform/cf/CoreMediaSoftLink.cpp:107 > > +SOFT_LINK_CONSTANT_FOR_SOURCE(WebCore, CoreMedia, kCMSampleAttachmentKey_IsDependedOnByOthers, CFStringRef) > > Unnecessary? > > > Source/WebCore/platform/cf/CoreMediaSoftLink.h:170 > > +SOFT_LINK_CONSTANT_FOR_HEADER(WebCore, CoreMedia, kCMSampleAttachmentKey_IsDependedOnByOthers, CFStringRef) > > +#define kCMSampleAttachmentKey_IsDependedOnByOthers get_CoreMedia_kCMSampleAttachmentKey_IsDependedOnByOthers() > > Ditto. Both removed. Thanks for the review!
Eric Carlson
Comment 6 2016-11-08 06:17:51 PST
Created attachment 294156 [details] Patch for landing.
WebKit Commit Bot
Comment 7 2016-11-09 10:30:41 PST
Comment on attachment 294156 [details] Patch for landing. Clearing flags on attachment: 294156 Committed r208444: <http://trac.webkit.org/changeset/208444>
Note You need to log in before you can comment on or make changes to this bug.