Bug 164469 - Web Automation: don't disable localStorage for ephemeral sessions that are being controlled by automation
Summary: Web Automation: don't disable localStorage for ephemeral sessions that are be...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-06 19:38 PST by Brian Burg
Modified: 2017-05-18 11:52 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2016-11-06 19:38:14 PST
.
Comment 1 Brian Burg 2016-11-06 20:49:08 PST
<rdar://problem/28137091>
Comment 2 Brady Eidson 2016-11-07 09:15:55 PST
Ephemeral sessions should *not* use the storage backend that actually stores to disk.

So this bug is, by necessity, more than just "don't disable localStorage for ..."

We'll need a mode for localStorage to use an in-memory backing store.
Comment 3 Brian Burg 2016-11-07 09:52:31 PST
(In reply to comment #2)
> Ephemeral sessions should *not* use the storage backend that actually stores
> to disk.
> 
> So this bug is, by necessity, more than just "don't disable localStorage for
> ..."
> 
> We'll need a mode for localStorage to use an in-memory backing store.

Does such a backing store already exist?

It seems sketchy to me that the file-based backend is hooked up to ephemeral sessions right now, and we rely on this check to prevent code from actually using it.
Comment 4 Brady Eidson 2016-11-07 10:11:09 PST
(In reply to comment #3)
> (In reply to comment #2)
> > Ephemeral sessions should *not* use the storage backend that actually stores
> > to disk.
> > 
> > So this bug is, by necessity, more than just "don't disable localStorage for
> > ..."
> > 
> > We'll need a mode for localStorage to use an in-memory backing store.
> 
> Does such a backing store already exist?

Yes - sessionStorage uses a per-WebView, in-memory backing store.

And that's exactly what we'll want to use for localStorage in a WebView whose storage session is ephemeral.
Comment 5 Brian Burg 2017-05-18 11:52:42 PDT
This bug is no longer needed.