Summary: DataView get methods should allow for missing offset, set methods should allow for missing value Yes, even though their length expects a value, it gracefully handles missing values. Steps to Reproduce: jsc> var buffer = new ArrayBuffer(8); jsc> var sample = new DataView(buffer, 0); jsc> sample.getUint8() => Throws exception. Should be the same as sample.getUint8(0), ToIndex(offset) would convert undefined to 0. jsc> sample.setUint8(0) => Throws exception. Should be the same as sample.setUint8(0, 0), ToNumber(value) would convert undefined to 0.
Created attachment 293996 [details] [PATCH] Proposed Fix
Created attachment 294420 [details] [PATCH] For Landing
Comment on attachment 294420 [details] [PATCH] For Landing Attachment 294420 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2493483 New failing tests: webgl/1.0.2/conformance/typedarrays/data-view-test.html fast/canvas/webgl/data-view-test.html
Created attachment 294433 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 294420 [details] [PATCH] For Landing Attachment 294420 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2493417 New failing tests: webgl/1.0.2/conformance/typedarrays/data-view-test.html fast/canvas/webgl/data-view-test.html
Created attachment 294434 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 294420 [details] [PATCH] For Landing Attachment 294420 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2493504 New failing tests: webgl/1.0.2/conformance/typedarrays/data-view-test.html fast/canvas/webgl/data-view-test.html
Created attachment 294435 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
> New failing tests: > webgl/1.0.2/conformance/typedarrays/data-view-test.html > fast/canvas/webgl/data-view-test.html Looks like these tests need to be updated.
Created attachment 294576 [details] [PATCH] For Landing
<https://trac.webkit.org/changeset/208639>
Follow-up fix for an ASSERT seen on the bots. I missed needing to converting an uncheckedArgument() to argument(): <https://trac.webkit.org/changeset/208643>