Bug 164444 - testWASM should be very sad if no options are provided
Summary: testWASM should be very sad if no options are provided
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords:
Depends on:
Blocks: 159775
  Show dependency treegraph
 
Reported: 2016-11-04 18:42 PDT by JF Bastien
Modified: 2016-11-04 19:51 PDT (History)
5 users (show)

See Also:


Attachments
patch (2.39 KB, patch)
2016-11-04 18:43 PDT, JF Bastien
sbarati: review+
sbarati: commit-queue-
Details | Formatted Diff | Diff
patch (2.40 KB, patch)
2016-11-04 18:51 PDT, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2016-11-04 18:42:10 PDT
Because I've been running it wrong all along.
Comment 1 JF Bastien 2016-11-04 18:43:43 PDT
Created attachment 293967 [details]
patch
Comment 2 Saam Barati 2016-11-04 18:47:38 PDT
Comment on attachment 293967 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293967&action=review

> Source/JavaScriptCore/testWasm.cpp:78
> +            continue;

Should be RELEASE_ASSERT_NOT_REACHED() IMO
Comment 3 JF Bastien 2016-11-04 18:51:50 PDT
Created attachment 293969 [details]
patch

Address comment.
Comment 4 WebKit Commit Bot 2016-11-04 19:51:16 PDT
Comment on attachment 293969 [details]
patch

Clearing flags on attachment: 293969

Committed r208413: <http://trac.webkit.org/changeset/208413>
Comment 5 WebKit Commit Bot 2016-11-04 19:51:19 PDT
All reviewed patches have been landed.  Closing bug.