Bug 164430 – AX: [ATK] Wrong selected element at a given index in a list box (redux)

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

Unfortunately I didn't notice bug 129039 or its associated "fix." However, the "bug" reported there is not a bug.

1. The AtkSelection documentation [1] states that atk_selection_ref_selection() takes "a gint specifying the index in the selection set. (e.g. the ith selection as opposed to the ith child)."

2. The method changed/broken even has a comment [2] which states "// i is the ith selection as opposed to the ith child."

3. There is different API, namely atk_object_ref_accessible_child(), when the ith child from the set of all children is sought. [3]

It's not clear to me what prompted the filing of, and commmitted change for, bug 129039. But that change needs to be undone.

[1] https://developer.gnome.org/atk/stable/AtkSelection.html#atk-selection-ref-selection
[2] https://trac.webkit.org/browser/trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp?rev=164577#L99
[3] https://developer.gnome.org/atk/stable/AtkObject.html#atk-object-ref-accessible-child

[Radar WebKit Bug Importer]

<rdar://problem/29117961>

[Joanmarie Diggs]

Created attachment 293926 [details]
Patch

[Build Bot]

Comment on attachment 293926 [details]
Patch

Attachment 293926 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2463649

New failing tests:
accessibility/select-element-at-index.html

[Build Bot]

Created attachment 293940 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293926 [details]
Patch

Attachment 293926 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2463657

New failing tests:
accessibility/select-element-at-index.html

[Build Bot]

Created attachment 293943 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293926 [details]
Patch

Attachment 293926 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2463658

New failing tests:
accessibility/select-element-at-index.html

[Build Bot]

Created attachment 293944 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Joanmarie Diggs]

Created attachment 293991 [details]
Patch

[Joanmarie Diggs]

Comment on attachment 293991 [details]
Patch

Chris, when you have a chance, would you please review this? Thanks in advance!

[WebKit Commit Bot]

Comment on attachment 293991 [details]
Patch

Clearing flags on attachment: 293991

Committed r208442: <http://trac.webkit.org/changeset/208442>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.