Bug 164424 - IndexedDB 2.0: Clean up more transaction abort and exception throwing behavior from IDBObjectStore
Summary: IndexedDB 2.0: Clean up more transaction abort and exception throwing behavio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 160306
  Show dependency tree / graph
 
Reported: 2016-11-04 13:13 PDT by Brady Eidson
Modified: 2016-11-04 16:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (31.06 KB, patch)
2016-11-04 14:50 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (32.20 KB, patch)
2016-11-04 14:57 PDT, Brady Eidson 		achristensen: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-yosemite (1.16 MB, application/zip)
2016-11-04 16:08 PDT, WebKit Commit Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (2.02 MB, application/zip)
2016-11-04 16:12 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (deleted)
2016-11-04 16:19 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-11-04 13:13:03 PDT 
IndexedDB 2.0: Clean up more transaction abort and exception throwing behavior from IDBObjectStore
Comment 1 Brady Eidson 2016-11-04 13:55:56 PDT 
This patch will actually shift a few PASSes to FAILs in the w3c tests, but those are problems in the spec that are under discussion, and not actually meaningful regressions.
Comment 2 Brady Eidson 2016-11-04 14:50:38 PDT 
Created attachment 293935 [details]
Patch
Comment 3 Brady Eidson 2016-11-04 14:51:21 PDT 
Forgot some changes, ignore that patch
Comment 4 Brady Eidson 2016-11-04 14:57:01 PDT 
Created attachment 293938 [details]
Patch
Comment 5 Alex Christensen 2016-11-04 15:00:02 PDT 
Comment on attachment 293938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293938&action=review

> LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor_advance_index7-expected.txt:2
> -PASS IDBCursor.advance() - index - throw TransactionInactiveError 
> +FAIL IDBCursor.advance() - index - throw TransactionInactiveError assert_throws: Calling advance() should throws an exception TransactionInactiveError when the transaction is not active. function "function () {

:(

> LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor_continue_index7-expected.txt:2
> -PASS IDBCursor.continue() - index - throw TransactionInactiveError 
> +FAIL IDBCursor.continue() - index - throw TransactionInactiveError assert_throws: Calling continue() should throws an exception TransactionInactiveError when the transaction is not active. function "function () {

:(
Comment 6 WebKit Commit Bot 2016-11-04 16:08:49 PDT 
Comment on attachment 293938 [details]
Patch

Rejecting attachment 293938 [details] from commit-queue.

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbindex_getKey7.html
imported/w3c/IndexedDB-private-browsing/idbcursor_continue_index7.html
imported/w3c/IndexedDB-private-browsing/idbindex_openCursor2.html
imported/w3c/IndexedDB-private-browsing/idbcursor_advance_index7.html
imported/w3c/IndexedDB-private-browsing/idbindex_get7.html
imported/w3c/IndexedDB-private-browsing/idbindex_openKeyCursor3.html
Full output: http://webkit-queues.webkit.org/results/2463924
Comment 7 WebKit Commit Bot 2016-11-04 16:08:51 PDT 
Created attachment 293950 [details]
Archive of layout-test-results from webkit-cq-01 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-11-04 16:12:52 PDT 
Comment on attachment 293938 [details]
Patch

Attachment 293938 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2463913

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbindex_getKey7.html
imported/w3c/IndexedDB-private-browsing/idbcursor_continue_index7.html
imported/w3c/IndexedDB-private-browsing/idbindex_openCursor2.html
imported/w3c/IndexedDB-private-browsing/idbcursor_advance_index7.html
imported/w3c/IndexedDB-private-browsing/idbindex_get7.html
imported/w3c/IndexedDB-private-browsing/idbindex_openKeyCursor3.html
Comment 9 Build Bot 2016-11-04 16:12:54 PDT 
Created attachment 293951 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-11-04 16:19:37 PDT 
Comment on attachment 293938 [details]
Patch

Attachment 293938 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2463939

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbindex_getKey7.html
imported/w3c/IndexedDB-private-browsing/idbcursor_continue_index7.html
imported/w3c/IndexedDB-private-browsing/idbindex_openCursor2.html
imported/w3c/IndexedDB-private-browsing/idbcursor_advance_index7.html
imported/w3c/IndexedDB-private-browsing/idbindex_get7.html
imported/w3c/IndexedDB-private-browsing/idbindex_openKeyCursor3.html
Comment 11 Build Bot 2016-11-04 16:19:42 PDT 
Created attachment 293955 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 12 Brady Eidson 2016-11-04 16:30:44 PDT 
Whoops, forgot to update the private tests copy.

Landing manually with those: https://trac.webkit.org/changeset/208405