Bug 164419 - Add layout test for input.setCustomValidity()
Summary: Add layout test for input.setCustomValidity()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 164382
  Show dependency tree / graph
 
Reported: 2016-11-04 12:01 PDT by Chris Dumez
Modified: 2016-11-04 13:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.39 KB, patch)
2016-11-04 12:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2016-11-04 12:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.05 KB, patch)
2016-11-04 13:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-11-04 12:01:43 PDT 
Add layout test for input.setCustomValidity().
Comment 1 Chris Dumez 2016-11-04 12:06:09 PDT 
Created attachment 293906 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-11-04 12:10:04 PDT 
Comment on attachment 293906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293906&action=review

> LayoutTests/fast/forms/validation-custom-message.html:16
> +        uiController.uiScriptComplete(JSON.stringify(uiController.contentsOfUserInterfaceItem('validationBubble')));

I don't think you need to call uiController.uiScriptComplete() to get the result through. Does it work if you just return the result from this function?
Comment 3 Chris Dumez 2016-11-04 12:15:03 PDT 
Created attachment 293910 [details]
Patch
Comment 4 Chris Dumez 2016-11-04 13:01:59 PDT 
Comment on attachment 293910 [details]
Patch

Forgot to skip the new test on WK1. Will do this before landing.
Comment 5 Chris Dumez 2016-11-04 13:03:43 PDT 
Created attachment 293916 [details]
Patch
Comment 6 WebKit Commit Bot 2016-11-04 13:51:17 PDT 
Comment on attachment 293916 [details]
Patch

Clearing flags on attachment: 293916

Committed r208397: <http://trac.webkit.org/changeset/208397>
Comment 7 WebKit Commit Bot 2016-11-04 13:51:22 PDT 
All reviewed patches have been landed.  Closing bug.