Bug 164413 - [Readable Streams API] Implement ReadableByteStreamController close()
Summary: [Readable Streams API] Implement ReadableByteStreamController close()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Romain Bellessort
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-04 06:37 PDT by Romain Bellessort
Modified: 2016-11-16 06:00 PST (History)
4 users (show)

See Also:


Attachments
Patch (11.26 KB, patch)
2016-11-04 06:55 PDT, Romain Bellessort
no flags Details | Formatted Diff | Diff
Patch (11.08 KB, patch)
2016-11-16 01:21 PST, Romain Bellessort
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Bellessort 2016-11-04 06:37:43 PDT
Implement close() method of ReadableByteStreamController
Comment 1 Romain Bellessort 2016-11-04 06:55:44 PDT
Created attachment 293884 [details]
Patch
Comment 2 WebKit Commit Bot 2016-11-07 12:38:37 PST
Comment on attachment 293884 [details]
Patch

Rejecting attachment 293884 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 293884, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ed.txt
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/streams/readable-byte-stream-controller-expected.txt.rej
patching file LayoutTests/streams/readable-byte-stream-controller.js
Hunk #1 FAILED at 61.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/streams/readable-byte-stream-controller.js.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2468790
Comment 3 Romain Bellessort 2016-11-16 01:21:13 PST
Created attachment 294927 [details]
Patch
Comment 4 Romain Bellessort 2016-11-16 05:33:43 PST
Comment on attachment 294927 [details]
Patch

Commit failed due to another patch that had been rolled out. The "new" version is simply a rebase.
Comment 5 WebKit Commit Bot 2016-11-16 06:00:42 PST
Comment on attachment 294927 [details]
Patch

Clearing flags on attachment: 294927

Committed r208790: <http://trac.webkit.org/changeset/208790>
Comment 6 WebKit Commit Bot 2016-11-16 06:00:46 PST
All reviewed patches have been landed.  Closing bug.