Bug 164407 – Web Inspector: Allow FolderTreeElement to display content when selected

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Currently, selecting a FolderTreeElement in the Resources sidebar will not change the content of the Resources tab.  This is awkward, and isn't a good experience for the user.

[Radar WebKit Bug Importer]

<rdar://problem/29106728>

[Devin Rousso]

Created attachment 293873 [details]
Patch

[Timothy Hatcher]

Screenshot?

[Devin Rousso]

Created attachment 293909 [details]
[Image] After Patch is applied

[Joseph Pecoraro]

Comment on attachment 293873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293873&action=review

> Source/WebInspectorUI/UserInterface/Views/CollectionContentView.css:33
> +    flex-grow: 1;

o.O

> Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js:43
> +        switch (this.representedObject.typeVerifier) {
> +        case WebInspector.Collection.TypeVerifier.Frame:

Style: Putting this large switch into a static function would make it way easier to read the constructor, and you could half the number of lines (returns instead of breaks).

> Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js:98
> +     // Public

Style: Weird whitespace.

> Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js:110
> +     // Private

Style: Weird whitespace.

> Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js:169
> +        let item = event.data.item;
> +        if (!item)
> +            return;

This seems unnecessarily safe. If Item Added doesn't contain an item, then that would be a bigger bug, workaround here hides it. Drop the early return and inline?

> Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js:178
> +        let item = event.data.item;
> +        if (!item)
> +            return;

Ditto

> Source/WebInspectorUI/UserInterface/Views/TitleView.css:36
> +    font-weight: lighter;

o.O

[WebKit Commit Bot]

Comment on attachment 293873 [details]
Patch

Clearing flags on attachment: 293873

Committed r208441: <http://trac.webkit.org/changeset/208441>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.