Bug 164405 - IndexedDB 2.0: Throw the correct exceptions during IDBObjectStore/IDBIndex renaming
Summary: IndexedDB 2.0: Throw the correct exceptions during IDBObjectStore/IDBIndex re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 160306
  Show dependency tree / graph
 
Reported: 2016-11-03 21:58 PDT by Brady Eidson
Modified: 2016-11-04 08:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.91 KB, patch)
2016-11-03 22:42 PDT, Brady Eidson 		achristensen: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.18 MB, application/zip)
2016-11-03 23:32 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.52 MB, application/zip)
2016-11-03 23:38 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.93 MB, application/zip)
2016-11-03 23:54 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-11-03 21:58:47 PDT 
IndexedDB 2.0: Throw the correct exceptions during IDBObjectStore/IDBIndex renaming
Comment 1 Brady Eidson 2016-11-03 22:42:44 PDT 
Created attachment 293868 [details]
Patch
Comment 2 Brady Eidson 2016-11-03 22:44:36 PDT 
Note: These tests still fail because the internal exception code is exposed, which it shouldn't be.

Covered by https://bugs.webkit.org/show_bug.cgi?id=164406
Comment 3 Build Bot 2016-11-03 23:32:49 PDT 
Comment on attachment 293868 [details]
Patch

Attachment 293868 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2459759

New failing tests:
storage/indexeddb/modern/index-rename-1.html
storage/indexeddb/modern/objectstore-rename-1-private.html
storage/indexeddb/modern/index-rename-1-private.html
storage/indexeddb/modern/objectstore-rename-1.html
Comment 4 Build Bot 2016-11-03 23:32:52 PDT 
Created attachment 293870 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-11-03 23:38:39 PDT 
Comment on attachment 293868 [details]
Patch

Attachment 293868 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2459770

New failing tests:
storage/indexeddb/modern/index-rename-1.html
storage/indexeddb/modern/objectstore-rename-1-private.html
storage/indexeddb/modern/index-rename-1-private.html
storage/indexeddb/modern/objectstore-rename-1.html
Comment 6 Build Bot 2016-11-03 23:38:42 PDT 
Created attachment 293871 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-11-03 23:54:54 PDT 
Comment on attachment 293868 [details]
Patch

Attachment 293868 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2459796

New failing tests:
storage/indexeddb/modern/objectstore-rename-1-private.html
storage/indexeddb/modern/index-rename-1.html
storage/indexeddb/modern/objectstore-rename-1.html
storage/indexeddb/modern/index-rename-1-private.html
Comment 8 Build Bot 2016-11-03 23:54:57 PDT 
Created attachment 293872 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Brady Eidson 2016-11-04 08:53:27 PDT 
https://trac.webkit.org/changeset/208383