Bug 164401 - [MAC][WK2] Add support for uiController.typeCharacterUsingHardwareKeyboard()
Summary: [MAC][WK2] Add support for uiController.typeCharacterUsingHardwareKeyboard()
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 164143
Blocks:
  Show dependency tree / graph
 
Reported: 2016-11-03 21:37 PDT by Chris Dumez
Modified: 2016-11-04 09:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.55 KB, patch)
2016-11-03 21:42 PDT, Chris Dumez 		buildbot: commit-queue-
Details | Formatted Diff | Diff
WIP patch (55.48 KB, patch)
2016-11-03 21:42 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (9.06 MB, application/zip)
2016-11-03 23:00 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-11-03 21:37:15 PDT 
Add support for uiController.typeCharacterUsingHardwareKeyboard() on Mac and use it to improve an existing test.
Comment 1 Chris Dumez 2016-11-03 21:42:11 PDT 
Created attachment 293857 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-11-03 21:42:34 PDT 
Created attachment 293858 [details]
WIP patch

Attaching something I hacked up a while back. I forget the state of it though.
Comment 3 Build Bot 2016-11-03 23:00:39 PDT 
Comment on attachment 293857 [details]
Patch

Attachment 293857 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2459581

New failing tests:
fast/forms/validation-messages.html
Comment 4 Build Bot 2016-11-03 23:00:43 PDT 
Created attachment 293869 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 5 Chris Dumez 2016-11-04 08:45:43 PDT 
(In reply to comment #3)
> Comment on attachment 293857 [details]
> Patch
> 
> Attachment 293857 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/2459581
> 
> New failing tests:
> fast/forms/validation-messages.html

For some reason, typeCharacterUsingHardwareKeyboard() seems to fail to type letter 'a' in the field on iOS. Works on Mac though.
Comment 6 Wenson Hsieh 2016-11-04 08:47:23 PDT 
I think you need to tap the input field in order for typeCharacterUsingHardwareKeyboard to work on WK2 iOS.
Comment 7 Chris Dumez 2016-11-04 09:21:38 PDT 
(In reply to comment #6)
> I think you need to tap the input field in order for
> typeCharacterUsingHardwareKeyboard to work on WK2 iOS.

Ok, so using typeCharacterUsingHardwareKeyboard() is not really helping me make my test cross platform (Mac and iOS) :/