Steps: 1. Open Console. 2. Type "a" 3. Press Arrow Down key. 4. Press Arrow Left key. 5. Erase console prompt (by pressing Cmd+A and Delete, for example). 6. Type "a". Expected: a|ddEventListener (Autocomple still works) Actual: a| (Autocomplete doesn't work any more) Notes: This is a recent regression. It works as expected in Safari Technology Preview 16.
<rdar://problem/29102408>
Created attachment 293838 [details] [Animated GIF] Bug
This regressed in https://trac.webkit.org/changeset/208248, which in turn was supposed fix another autocomplete regression.
Created attachment 294887 [details] Patch Unroll r208248.
Created attachment 294888 [details] [Animated GIF] With patch applied
Created attachment 294890 [details] Patch
Comment on attachment 294890 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294890&action=review > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:164 > + delete this._ignoreNextCursorActivity; Why were the two remaining properties changed to delete? > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:250 > + var container = document.createElement("span"); Nit: let > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:251 > + container.classList.add(WebInspector.CodeMirrorCompletionController.CompletionHintStyleClassName); Since the class name was removed from CodeMirrorCompletionController.prototype._applyCompletionHint I think we can just inline the class name. > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:273 > + var currentText = this._codeMirror.getRange(from, cursor); Why did these change from let to var? > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:283 > + delete this._ignoreChange; Why the change? > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:322 > + var history = this._codeMirror.getHistory(); Nit: let > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:381 > + delete this._ignoreChange; Why the change? > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:835 > + delete this._ignoreNextCursorActivity; Same as above.
Doh! Nevermind.
Comment on attachment 294890 [details] Patch Clearing flags on attachment: 294890 Committed r208774: <http://trac.webkit.org/changeset/208774>
All reviewed patches have been landed. Closing bug.