Bug 164384 - Add new 'other' Apple Pay button style
Summary: Add new 'other' Apple Pay button style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-03 16:14 PDT by Anders Carlsson
Modified: 2016-11-04 12:19 PDT (History)
0 users

See Also:

Attachments
Patch (8.09 KB, patch)
2016-11-03 16:17 PDT, Anders Carlsson 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-11-03 16:14:49 PDT 
Add new 'other' Apple Pay button style
Comment 1 Anders Carlsson 2016-11-03 16:17:51 PDT 
Created attachment 293820 [details]
Patch
Comment 2 Dean Jackson 2016-11-03 17:05:11 PDT 
Comment on attachment 293820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293820&action=review

> Source/WebCore/css/parser/CSSParser.cpp:1042
> +    case CSSPropertyApplePayButtonType: // plain | buy | set-up | other
> +        if (valueID == CSSValuePlain || valueID == CSSValueBuy || valueID == CSSValueSetUp || valueID == CSSValueOther)

This reminds me: you need code in CSSPropertyParser too (the new CSS parser)
Comment 3 Anders Carlsson 2016-11-04 10:44:05 PDT 
Comment on attachment 293820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293820&action=review

>> Source/WebCore/css/parser/CSSParser.cpp:1042
>> +        if (valueID == CSSValuePlain || valueID == CSSValueBuy || valueID == CSSValueSetUp || valueID == CSSValueOther)
> 
> This reminds me: you need code in CSSPropertyParser too (the new CSS parser)

I think that's CSSParserFastPaths.cpp.
Comment 4 Anders Carlsson 2016-11-04 12:19:32 PDT 
Committed r208392: <http://trac.webkit.org/changeset/208392>