Bug 164373 - Use #pragma once in WebCore
Summary: Use #pragma once in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-03 12:21 PDT by Joseph Pecoraro
Modified: 2016-11-12 12:36 PST (History)
2 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (267.55 KB, patch)
2016-11-03 12:27 PDT, Joseph Pecoraro 		darin: review+
Details | Formatted Diff | Diff
[PATCH] For Bots (265.16 KB, patch)
2016-11-11 23:31 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] For Landing (275.32 KB, patch)
2016-11-12 00:22 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-11-03 12:21:39 PDT 
Use #pragma once more in WebCore.

This gets a bunch of other top level directories.
Comment 1 Joseph Pecoraro 2016-11-03 12:27:59 PDT 
Created attachment 293788 [details]
[PATCH] Proposed Fix

Lets see what the bots say.
Comment 2 WebKit Commit Bot 2016-11-03 12:31:25 PDT 
Attachment 293788 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:16:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:17:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:18:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 11 in 448 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2016-11-05 23:06:47 PDT 
Comment on attachment 293788 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=293788&action=review

> Source/WebCore/ChangeLog:22
> +        Remove unused DEBUG defines.

DEBUG doesn’t seem 100% accurate here.
Comment 4 Joseph Pecoraro 2016-11-11 23:31:08 PST 
Created attachment 294603 [details]
[PATCH] For Bots
Comment 5 WebKit Commit Bot 2016-11-11 23:34:11 PST 
Attachment 294603 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:16:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:17:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:18:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 11 in 444 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Joseph Pecoraro 2016-11-12 00:22:52 PST 
Created attachment 294608 [details]
[PATCH] For Landing

Bots all look good. Lets try commit-queue!
Comment 7 WebKit Commit Bot 2016-11-12 01:00:34 PST 
Comment on attachment 294608 [details]
[PATCH] For Landing

Clearing flags on attachment: 294608

Committed r208646: <http://trac.webkit.org/changeset/208646>