Bug 164370 - [Win][Direct2D] Native Windows widgets are drawn upside-down
Summary: [Win][Direct2D] Native Windows widgets are drawn upside-down
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-03 10:31 PDT by Brent Fulgham
Modified: 2016-11-03 12:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2016-11-03 10:34 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch v2 (2.08 KB, patch)
2016-11-03 10:54 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-11-03 10:31:42 PDT 
The concept of up/down in GDI is inverted compared to Direct2D. We need to properly flip the context of any bitmaps generated by dropping into GDI code paths.
Comment 1 Brent Fulgham 2016-11-03 10:34:39 PDT 
Created attachment 293775 [details]
Patch
Comment 2 WebKit Commit Bot 2016-11-03 10:36:57 PDT 
Attachment 293775 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2016-11-03 10:54:50 PDT 
Created attachment 293780 [details]
Patch v2

Correct tabs in Changelog.
Comment 4 Alex Christensen 2016-11-03 11:37:19 PDT 
Comment on attachment 293780 [details]
Patch v2

lol
Comment 5 WebKit Commit Bot 2016-11-03 12:12:40 PDT 
Comment on attachment 293780 [details]
Patch v2

Clearing flags on attachment: 293780

Committed r208339: <http://trac.webkit.org/changeset/208339>
Comment 6 WebKit Commit Bot 2016-11-03 12:12:45 PDT 
All reviewed patches have been landed.  Closing bug.