RESOLVED FIXED 164363
[Win] Page visibility tests are timing out.
https://bugs.webkit.org/show_bug.cgi?id=164363
Summary [Win] Page visibility tests are timing out.
Per Arne Vollan
Reported 2016-11-03 03:43:20 PDT
We need to implement page visibility methods in TestRunner.
Attachments
Patch (7.41 KB, patch)
2016-11-03 04:10 PDT, Per Arne Vollan
no flags
Per Arne Vollan
Comment 1 2016-11-03 03:59:51 PDT
Per Arne Vollan
Comment 2 2016-11-03 04:10:28 PDT
Brent Fulgham
Comment 3 2016-11-03 10:16:52 PDT
Comment on attachment 293757 [details] Patch Excellent! More test coverage :-) r=me.
Per Arne Vollan
Comment 4 2016-11-04 02:14:51 PDT
Comment on attachment 293757 [details] Patch Thanks for reviewing :)
WebKit Commit Bot
Comment 5 2016-11-04 02:38:35 PDT
Comment on attachment 293757 [details] Patch Clearing flags on attachment: 293757 Committed r208381: <http://trac.webkit.org/changeset/208381>
WebKit Commit Bot
Comment 6 2016-11-04 02:38:38 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2016-11-04 08:56:26 PDT
(In reply to comment #5) > Comment on attachment 293757 [details] > Patch > > Clearing flags on attachment: 293757 > > Committed r208381: <http://trac.webkit.org/changeset/208381> It broke the WinCairo build, see build.webkit.org for details.
Brent Fulgham
Comment 8 2016-11-04 09:21:08 PDT
(In reply to comment #7) > (In reply to comment #5) > > Comment on attachment 293757 [details] > > Patch > > > > Clearing flags on attachment: 293757 > > > > Committed r208381: <http://trac.webkit.org/changeset/208381> > > It broke the WinCairo build, see build.webkit.org for details. Seems fine now. Looks like it needed to clear out some old headers.
Note You need to log in before you can comment on or make changes to this bug.