Bug 164363 - [Win] Page visibility tests are timing out.
Summary: [Win] Page visibility tests are timing out.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-03 03:43 PDT by Per Arne Vollan
Modified: 2016-11-04 09:21 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.41 KB, patch)
2016-11-03 04:10 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-11-03 03:43:20 PDT 
We need to implement page visibility methods in TestRunner.
Comment 1 Per Arne Vollan 2016-11-03 03:59:51 PDT 
<rdar://problem/15011796>
Comment 2 Per Arne Vollan 2016-11-03 04:10:28 PDT 
Created attachment 293757 [details]
Patch
Comment 3 Brent Fulgham 2016-11-03 10:16:52 PDT 
Comment on attachment 293757 [details]
Patch

Excellent! More test coverage :-) r=me.
Comment 4 Per Arne Vollan 2016-11-04 02:14:51 PDT 
Comment on attachment 293757 [details]
Patch

Thanks for reviewing :)
Comment 5 WebKit Commit Bot 2016-11-04 02:38:35 PDT 
Comment on attachment 293757 [details]
Patch

Clearing flags on attachment: 293757

Committed r208381: <http://trac.webkit.org/changeset/208381>
Comment 6 WebKit Commit Bot 2016-11-04 02:38:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Csaba Osztrogonác 2016-11-04 08:56:26 PDT 
(In reply to comment #5)
> Comment on attachment 293757 [details]
> Patch
> 
> Clearing flags on attachment: 293757
> 
> Committed r208381: <http://trac.webkit.org/changeset/208381>

It broke the WinCairo build, see build.webkit.org for details.
Comment 8 Brent Fulgham 2016-11-04 09:21:08 PDT 
(In reply to comment #7)
> (In reply to comment #5)
> > Comment on attachment 293757 [details]
> > Patch
> > 
> > Clearing flags on attachment: 293757
> > 
> > Committed r208381: <http://trac.webkit.org/changeset/208381>
> 
> It broke the WinCairo build, see build.webkit.org for details.

Seems fine now. Looks like it needed to clear out some old headers.