Bug 164360 - Reduce PassRefPtr use in WebKit2
Summary: Reduce PassRefPtr use in WebKit2
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-02 23:55 PDT by Alex Christensen
Modified: 2022-09-17 17:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (28.31 KB, patch)
2016-11-02 23:56 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (29.34 KB, patch)
2016-11-03 09:24 PDT, Alex Christensen 		thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (2.50 MB, application/zip)
2016-11-03 15:53 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-11-02 23:55:39 PDT 
Reduce PassRefPtr use in WebKit2
Comment 1 Alex Christensen 2016-11-02 23:56:22 PDT 
Created attachment 293752 [details]
Patch
Comment 2 Alex Christensen 2016-11-03 09:24:17 PDT 
Created attachment 293768 [details]
Patch
Comment 3 Tim Horton 2016-11-03 10:50:01 PDT 
Comment on attachment 293768 [details]
Patch

Make the bots green, plz.
Comment 4 Alex Christensen 2016-11-03 10:50:47 PDT 
http://trac.webkit.org/changeset/208330
Comment 5 Ryan Haddad 2016-11-03 13:53:24 PDT 
This change appears to have caused these LayoutTests to fail:

editing/selection/context-menu-on-text.html
editing/spelling/context-menu-suggestions.html

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r208330%20(1201)/results.html
Comment 6 Ryan Haddad 2016-11-03 13:56:00 PDT 
Reverted r208330 for reason:

This change appears to have caused two editing tests to fail on macOS.

Committed r208342: <http://trac.webkit.org/changeset/208342>
Comment 7 Ryan Haddad 2016-11-03 15:15:38 PDT 
It looks like this change was also responsible for these LayoutTest crashes (which stopped occurring after the rollout):

https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/builds/16058
Comment 8 Build Bot 2016-11-03 15:53:49 PDT 
Comment on attachment 293768 [details]
Patch

Attachment 293768 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2456732

New failing tests:
editing/mac/selection/context-menu-select-editability.html
editing/selection/context-menu-text-selection-lookup.html
editing/selection/button-right-click.html
editing/selection/context-menu-text-selection.html
fast/events/selectstart-prevent-selection-on-right-click.html
editing/selection/context-menu-on-text.html
editing/selection/minimal-user-select-crash.html
media/controls-right-click-on-timebar.html
editing/spelling/spellcheck-input-search-crash.html
editing/spelling/context-menu-suggestions.html
fast/events/contextmenu-scrolled-page-with-frame.html
editing/selection/empty-cell-right-click.html
fast/events/context-no-deselect.html
Comment 9 Build Bot 2016-11-03 15:53:52 PDT 
Created attachment 293813 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 10 Ahmad Saleem 2022-09-17 17:01:59 PDT 
PassRefPtr usage does not exist anymore in Webkit GitHub as of today. So I am marking this as "RESOLVED WONTFIX". Thanks!