REGRESSION (r208025) GraphicsContext state stack assertions loading webkit.org
Created attachment 293719 [details] Patch
Comment on attachment 293719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293719&action=review > Source/WebCore/ChangeLog:10 > + This confused the RenderLayer paintWithTransparency code, triggering mismsatched GrpahicsContext typo graphics > Source/WebCore/ChangeLog:17 > + Rather than depend on the super confusing animation state, use a bool out param from animate() to say Nit: super-confusing :) > Source/WebCore/ChangeLog:26 > + (WebCore::CSSPropertyAnimation::blendProperties): Log after blending so the log shows the blended style. Haha. > Source/WebCore/page/animation/CompositeAnimation.cpp:336 > - bool runningOrFillingForwards = !keyframeAnim->waitingToStart() && !keyframeAnim->postActive(); > - forceStackingContext |= runningOrFillingForwards && keyframeAnim->triggersStackingContext(); > + forceStackingContext |= didBlendStyle && keyframeAnim->triggersStackingContext(); Are you sure that didBlendStyle covers !keyframeAnim->waitingToStart() && !keyframeAnim->postActive()?
(In reply to comment #2) > > Source/WebCore/page/animation/CompositeAnimation.cpp:336 > > - bool runningOrFillingForwards = !keyframeAnim->waitingToStart() && !keyframeAnim->postActive(); > > - forceStackingContext |= runningOrFillingForwards && keyframeAnim->triggersStackingContext(); > > + forceStackingContext |= didBlendStyle && keyframeAnim->triggersStackingContext(); > > Are you sure that didBlendStyle covers !keyframeAnim->waitingToStart() && > !keyframeAnim->postActive()? Yes, because animate() only sets it to true when it produces new style.
https://trac.webkit.org/r208314
Followup to fix reflections asserting in https://trac.webkit.org/r208319