In order to allow folder's to be selectable and show content, it it necessary for them to know what content to display. Now that we have the general WI.Collection model object, we can leverage this by making all WI.FolderTreeElement instances have a representedObject that is a WI.Collection of all its children.
<rdar://problem/29078775>
Created attachment 293712 [details] Patch
Comment on attachment 293712 [details] Patch Matt, can you review this. It touches code you added, re: countChildrenCallback.
Comment on attachment 293712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293712&action=review r=me, use of Collection really makes this code cleaner! > Source/WebInspectorUI/UserInterface/Views/FolderTreeElement.js:28 > + constructor(title, representedObject) Nice cleanup. > Source/WebInspectorUI/UserInterface/Views/FolderTreeElement.js:35 > + super(classNames, title, subtitle, representedObject, hasChildren); Just naming the bool is probably sufficient, but I don't feel too strongly about it. > Source/WebInspectorUI/UserInterface/Views/FrameTreeElement.js:56 > + for (let [key, value] of Object.entries(WebInspector.Resource.Type)) { Object.entries, cool!
Comment on attachment 293712 [details] Patch Clearing flags on attachment: 293712 Committed r208337: <http://trac.webkit.org/changeset/208337>
All reviewed patches have been landed. Closing bug.