Give IDBKey(Data) a WTF::Variant overhaul
Created attachment 293697 [details] Patch
Comment on attachment 293697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293697&action=review > Source/WebCore/Modules/indexeddb/IDBKey.cpp:39 > +IDBKey::IDBKey() > + : m_type(KeyType::Invalid) > + , m_sizeEstimate(OverheadSize) > +{ > +} This should just use initializer lists in the header.
Comment on attachment 293697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293697&action=review > Source/WebCore/Modules/indexeddb/IDBKey.cpp:89 > + const auto& array = WTF::get<Vector<RefPtr<IDBKey>>>(m_value); > + const auto& otherArray = WTF::get<Vector<RefPtr<IDBKey>>>(other.m_value); Vector<RefPtr<IDBKey>> could benefit from a type alias. I would omit the const here, but I don't feel strongly about that. You added similar code below (in IDBKeyData.cpp) that omits const, so maybe at least be consistent. > Source/WebCore/Modules/indexeddb/IDBKey.cpp:105 > + double number = WTF::get<double>(m_value); > + double otherNumber = WTF::get<double>(other.m_value); I'd use auto here.
Comment on attachment 293697 [details] Patch Attachment 293697 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2452648 New failing tests: svg/wicd/test-rightsizing-b.xhtml
Created attachment 293702 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
https://trac.webkit.org/changeset/208310
(In reply to comment #4) > Comment on attachment 293697 [details] > Patch > > Attachment 293697 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/2452648 > > New failing tests: > svg/wicd/test-rightsizing-b.xhtml This failure has nothing to do with this patch.